Skip to content
This repository has been archived by the owner on Apr 15, 2021. It is now read-only.

Testnet should support https #114

Open
njordhov opened this issue Aug 13, 2020 · 1 comment
Open

Testnet should support https #114

njordhov opened this issue Aug 13, 2020 · 1 comment

Comments

@njordhov
Copy link

njordhov commented Aug 13, 2020

Describe the bug

Testnet uses http protocol rather than https.

This may cause issues for dapps using stracks-transactions-js when served with an https protocol.

Steps To Reproduce

https://github.com/blockstack/stacks-transactions-js/blob/e86e2b11be27612532aa5ca131d036aa89190c12/src/network.ts#L51

Expected behavior

Testnet has a url with https protocol.

@hstove
Copy link
Contributor

hstove commented Aug 14, 2020

Yeah - in the authenticator, we are overriding this URL to use the HTTPS sidecar URL. https://github.com/blockstack/ux/blob/fix/570_postconditions/packages/keychain/src/wallet/signer.ts#L68:L70

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants