Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration tests where the signer set size changes between cycles #5611

Open
obycode opened this issue Dec 23, 2024 · 0 comments
Open
Assignees
Milestone

Comments

@obycode
Copy link
Contributor

obycode commented Dec 23, 2024

We ran into an issue where this caused a stall, because the previous signer responded to a block validate response for the current cycle, and because the signer set had changed, it thought the block had crossed the threshold, because it had for cycle N-1, but it actually had not for cycle N. This scenario is not fully tested in our integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

3 participants