You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The template components (Button.jsx, etc.) uses the prop-types package to define prop types, but that package isn't added as a dependency, so starting Storybook results in a Webpack compile error.
Presumably prop-types was already part of Next.js with React 18, but not with React 19.
But we don't do that for Next.js. The quick fix would be to also the dependency in Next.js + JavaScript projects. But given the package has finally been removed from React in v19, we're actually adding legacy practices now with every init, so long term we should update our template components to not rely on prop-types. I don't know if react-docgen and/or react-docgen-typescript supports JSDoc types?
Reproduction link
Reproduction steps
System
-
Additional context
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
The template components (Button.jsx, etc.) uses the prop-types package to define prop types, but that package isn't added as a dependency, so starting Storybook results in a Webpack compile error.
Presumably prop-types was already part of Next.js with React 18, but not with React 19.
But we don't do that for Next.js. The quick fix would be to also the dependency in Next.js + JavaScript projects. But given the package has finally been removed from React in v19, we're actually adding legacy practices now with every init, so long term we should update our template components to not rely on prop-types. I don't know if react-docgen and/or react-docgen-typescript supports JSDoc types?
Reproduction link
Reproduction steps
System
Additional context
No response
The text was updated successfully, but these errors were encountered: