We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two options:
Uniswap style (with amount) https://github.com/Uniswap/uniswap-v2-core/blob/10be569bd35c827c3935413b32a40fa5f2b0d8b7/contracts/UniswapV2ERC20.sol#L81
DAI style (binary on/off) https://github.com/makerdao/dss/blob/master/src/dai.sol#L118
The text was updated successfully, but these errors were encountered:
Here’s an example PR of me adding this functionality to the @ourzora ERC20 tokens: https://github.com/ourzora/zora-contracts/pull/5/files
Happy to submit a PR with this extracted + tests. Do you have a preference on the signature (uniswap vs dai)?
Sorry, something went wrong.
@kern I prefer the Uniswap way personally (imo worth considering changing in @ourzora)
@haydenadams Noted, the uniswap approach is a superset of functionality. Will update the @ourzora implementation this weekend sometime.
No branches or pull requests
Two options:
Uniswap style (with amount)
https://github.com/Uniswap/uniswap-v2-core/blob/10be569bd35c827c3935413b32a40fa5f2b0d8b7/contracts/UniswapV2ERC20.sol#L81
DAI style (binary on/off)
https://github.com/makerdao/dss/blob/master/src/dai.sol#L118
The text was updated successfully, but these errors were encountered: