Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for lifecycle_rule variable #304

Open
okanmenevseoglu opened this issue Jan 21, 2025 · 1 comment
Open

Add validation for lifecycle_rule variable #304

okanmenevseoglu opened this issue Jan 21, 2025 · 1 comment

Comments

@okanmenevseoglu
Copy link

Motivation and Context

In my company, we experienced that passing an incorrect map doesn't break the plan & apply pipelines but it also doesn't actually apply the required change. The main reason for this change is also that the configuration in this module is slightly different than what is explained on aws_s3_bucket_lifecycle_configuration which users usually confuse with.

I can implement this and I did create an MR to add this support but it was rejected for an unclear reason.

Could you please tell me the best way to do this?

@okanmenevseoglu okanmenevseoglu changed the title Add validation for lifecycle_rule along with terraform tests Add validation for lifecycle_rule variable Jan 21, 2025
@okanmenevseoglu
Copy link
Author

One example I can give to above is that I observed users may pass abort_incomplete_multipart_upload block instead of abort_incomplete_multipart_upload_days variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant