Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEEP_CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY shouldn't be required by default for deployments #84

Open
cygnusv opened this issue Feb 23, 2022 · 2 comments

Comments

@cygnusv
Copy link
Member

cygnusv commented Feb 23, 2022

Trying to deploy something on mainnet I got this ropsten related error:
Invalid account: #1 for network: ropsten - Expected string, received undefined

It seems that even though I'm deploying on mainnet, the ropsten accounts configuration is still processed and since process.env.CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY is set, it also expects process.env.KEEP_CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY, which I shouldn't have set for deployments not related to legacy Keep.

For reference, this is ropsten config on hardhat.config.ts:

ropsten: {
      url: process.env.CHAIN_API_URL || "",
      chainId: 3,
      accounts: process.env.CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY
        ? [
            process.env.CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY,
            process.env.KEEP_CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY,
          ]
        : undefined,
      tags: ["tenderly"],
    },
@michalinacienciala
Copy link
Contributor

@cygnus, so you were running something like "yarn deploy --network mainnet" or "hardhat deploy --network mainnet" and got an error related to ropsten network configuration? That looks like a bug in hardhat...

@cygnusv
Copy link
Member Author

cygnusv commented Nov 24, 2023

Bumping. This still happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants