Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting custom TLS ciphers #131

Open
mattgahs opened this issue Nov 6, 2023 · 2 comments
Open

Allow setting custom TLS ciphers #131

mattgahs opened this issue Nov 6, 2023 · 2 comments

Comments

@mattgahs
Copy link
Contributor

mattgahs commented Nov 6, 2023

Hello!

I need to disable some TLS ciphers in the mokey web service. What's the best way to do so?

Specifically:

TLSv1.2:

  • ECDHE-RSA-AES128-SHA256
  • ECDHE-RSA-CHACHA20-POLY1304

TLSv1.3:

  • TLS_AES_128_GCM_SHA256
  • TLS_CHACHA20_POLY1305_SHA256

Thanks!

@Aterfax
Copy link

Aterfax commented Nov 6, 2023

Looks like mokey might need some amendments in the code to implement the setting of this in the TOML file / via options from https://pkg.go.dev/net/http#hdr-Clients_and_Transports

For now I would recommend configuring a reverse proxy with the OS native NGINX / Apache or something like the SWAG docker.

@aebruno
Copy link
Member

aebruno commented Nov 7, 2023

@mattgahs We currently do not support setting custom TLS ciphers. As @Aterfax mentioned, you have a few options:

  1. Run mokey behind nginx (or another webserver) using proxy pass and configure your custom ciphers there
  2. Modify the code here to support setting a custom tls.Config with your custom cipher list. see here

I'll add this issue as a feature so in the future we can support custom ciphers. If you do end up implementing option 2 feel free to submit a PR.

@aebruno aebruno changed the title How to disable verboten TLS ciphers Allow setting custom TLS ciphers Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants