-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange caching bug related to the EquateR function somehow #713
Comments
So this must be some sort of variable that does not get reset properly |
Interestingly the failure does not happen on windows |
This was a very(!) tricky one to debug, but the default value for integers in FORTRAN is 1, not 0. Implicit variable initialization is a very bad idea. Not sure why valgrind never flagged this. See https://github.com/ianhbell/refprop-sandbox/commit/6d6552a407bd726e78b699a5258f73af9dac7d2d |
In the end the variable had to be left uninitialized within the function, relying on the value passed in. Nevertheless, fixed the problem |
Not fixed. Now I am getting uninitialized variable errors with iRcount in the [nearvap] Catch tag on intel on windows. On non-windows, I get no valgrind errors |
See #710, if the first call to a totally unrelated mixture is made, the error code from the second call differs to when the call is not made
yielding
but if the R410A line is commented out, you get:
The text was updated successfully, but these errors were encountered: