Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment with Hardhat :: Initial Public Functions #132

Closed
5 of 6 tasks
nwbrettski opened this issue Oct 20, 2023 · 2 comments · Fixed by #178
Closed
5 of 6 tasks

Alignment with Hardhat :: Initial Public Functions #132

nwbrettski opened this issue Oct 20, 2023 · 2 comments · Fixed by #178
Assignees
@rodolfopietro97 @pierobassa @fabiorigam
Labels
Type: Feature

Comments

@nwbrettski
Copy link
Collaborator

nwbrettski commented Oct 20, 2023 •
edited
Loading

As a user I want to have convenient functions and alignment with hardhat functions so that I can easily develop on vechain when compared to ethereum or other EVM compatible chains.

Acceptance Criteria:

- [] constructor
- [] provider
- [] destroy
@nwbrettski nwbrettski mentioned this issue Oct 20, 2023
Closed
12 tasks
@nwbrettski nwbrettski changed the title Provider Alignment with Hardhat :: Initial Public Functions Alignment with Hardhat :: Initial Public Functions Oct 26, 2023
@pierobassa pierobassa self-assigned this Oct 29, 2023
@pierobassa pierobassa linked a pull request Oct 30, 2023 that will close this issue
feat: Hardhat compatibility (Part 1 - Provider interface) #178
Merged
@nwbrettski
Copy link
Collaborator Author

@pierobassa I have modified the above based on your comments here. I believe that the remaining functions can be created based on your commentary, is this correct?

I am unsure about the constructor and provider as they are not within your comments.

@pierobassa
Copy link
Member

Thank you @nwbrettski ! constructor and provider are simple implementations that are not part of the interface:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodolfopietro97 rodolfopietro97

@pierobassa pierobassa

@fabiorigam fabiorigam

Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Hardhat compatibility (Part 1 - Provider interface) vechain/vechain-sdk-js
4 participants
@nwbrettski @rodolfopietro97 @pierobassa @fabiorigam