Skip to content
This repository has been archived by the owner on Nov 4, 2021. It is now read-only.

Optimize broadcasting with sending a prepared websocket frame #235

Open
vladbat00 opened this issue Jan 5, 2019 · 3 comments
Open

Optimize broadcasting with sending a prepared websocket frame #235

vladbat00 opened this issue Jan 5, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@vladbat00
Copy link
Owner

vladbat00 commented Jan 5, 2019

See websockets/ws#617 to get the idea

@vladbat00 vladbat00 added the enhancement New feature or request label Jan 5, 2019
@vladbat00 vladbat00 added this to the v0.1.0 milestone Jan 5, 2019
@adamkaplan
Copy link

adamkaplan commented Jun 10, 2019

The code in referenced issue has expanded use now. It works extremely well, super efficient when the use case is pure broadcast. Supporting over 500,000 connections (avg/minute) with high broadcast data rate. We stopped pushing the connection counts up on the WS hosts because the costs got low enough that it didn't matter :-)

@vladbat00
Copy link
Owner Author

@adamkaplan, thanks for reaching out!

The code in referenced issue has expanded use now

By "now" do you mean that some changes were made to the code or ws library got improved? Or you just mean that you started using the code even more? :)

Btw, I stopped working on this project for now.. And I'm not sure whether I'll get back to it and apply that code. Though I found the discussion in the issue quite interesting and informative, thanks for your time sharing your approach to the problem.

@adamkaplan
Copy link

adamkaplan commented Aug 7, 2019

Just noticed this- I meant that the code is used “even more” now. I haven’t checked the stats but it is likely “broadcast”ing a hundred million websocket messages a day :)

I hope you find the motivation to spend some cycles on WS at some point. I don’t think it needs much to survive, given the good current state. Thanks for your efforts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants