Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: in capacity plugin attr.deserved no need MinDimensionResource with attr.request #3944

Open
kingeasternsun opened this issue Dec 31, 2024 · 0 comments · May be fixed by #3946
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kingeasternsun
Copy link
Contributor

kingeasternsun commented Dec 31, 2024

What is the problem you're trying to solve

In capacity plugin attr.deserved no need MinDimensionResource with attr.request.
In proportion plugin, attr.deserved is computed dynamically using min-max faire share algorithm, so attr.deserved needs MinDimensionResource with attr.request to share the ununsed quota with other queues.
But in capacity plugin, attr.deserved is configured by the user, so the MinDimensionResource is not need any more.

Describe the solution you'd like

Just move this line in OnSessionOpen of capacity plugin.
attr.deserved = helpers.Max(attr.deserved, attr.guarantee)

Additional context

I will do the PR.

@kingeasternsun kingeasternsun added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
1 participant