Port collision between nREPL server and web server is not reported #179
Comments
|
I'm very low on bandwidth right now, but I did a quick look around on this and it looks like one option is handled by lein-ring and one is handled by another ring lib, so it's not surprising they're never sanity-checked against one another. |
|
In this case I would expect the web server to abort with an error message, not due to port number collision but because the web server failed to bind server at the port. |
|
Fair, I'll have a look at the library doing the serving and see if I can
improve the error reporting.
…On Mon, Dec 19, 2016 at 10:28 PM Shantanu Kumar ***@***.***> wrote:
In this case I would expect the web server to abort with an error message,
not due to port number collision but because the web server failed to bind
server at the port.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#179 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMv1dDloknCDFw_WabfuJZ9PhSTYug-ks5rJ3WSgaJpZM4LEPDc>
.
|
|
Huh, I'm confused, I see an error. project.clj: result: |
|
I found the error with lein-ring (defproject foo "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:min-lein-version "2.0.0"
:dependencies [[org.clojure/clojure "1.8.0"]
[compojure "1.5.1"]
[ring/ring-defaults "0.2.1"]]
:plugins [[lein-ring "0.10.0"]]
:ring {:handler foo.handler/app
:port 1234
:nrepl {:start? true :port 1234}}
:profiles
{:dev {:dependencies [[javax.servlet/servlet-api "2.5"]
[ring/ring-mock "0.3.0"]]}}) |
|
what lein are you using?
…On Sun, Jan 1, 2017 at 8:44 PM Shantanu Kumar ***@***.***> wrote:
I found the error with lein-ring 0.9.7, but I verified it occurs in 0.10.0
too. For me the error happens as I reported even when I change the port
numbers to 1234. The project.clj is as follows:
(defproject foo "0.1.0-SNAPSHOT"
:description "FIXME: write description"
:url "http://example.com/FIXME"
:min-lein-version "2.0.0"
:dependencies [[org.clojure/clojure "1.8.0"]
[compojure "1.5.1"]
[ring/ring-defaults "0.2.1"]]
:plugins [[lein-ring "0.10.0"]]
:ring {:handler foo.handler/app
:port 1234
:nrepl {:start? true :port 1234}}
:profiles
{:dev {:dependencies [[javax.servlet/servlet-api "2.5"]
[ring/ring-mock "0.3.0"]]}})
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#179 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMv1S5cN5En554yxo4RP4LOYM8dGzzOks5rOICcgaJpZM4LEPDc>
.
|
|
Lein |
|
Tried your exact project, Leiningen 2.7.1 on Java 1.8.0_111 OpenJDK 64-Bit Server VM, Ubuntu 16.04, I get a traceback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the nREPL port and web server port are the same, there is no error reported and the web server fails to start. Steps to reproduce the issue are below:
$ lein new compojure foo $ cd fooEdit
project.cljas follows::ring {:handler foo.handler/app :nrepl {:start? true :port 3000}}Now try to start the server:
Now, connecting to nREPL server works, but the web server does not.
The text was updated successfully, but these errors were encountered: