🦋 Changeset detected

Latest commit: 9861f42

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This is great, thanks! Could you either update the package fixture to use React 19, or create a copy that is updated so there's still a test for React 18?

This is great, thanks! Could you either update the package fixture to use React 19, or create a copy that is updated so there's still a test for React 18?

Can do. Something changed in React 19 that caused the tests to fail, either that or maybe there's a mismatch in React versions. (not entirely sure yet how the fixtures resolve react dependency)

I will probably have a look over the weekend

@ascorbic The tests are working again! It turns out the issue was caused by the fixtures importing the development build of React while rendering with the production build. This behavior rendered fine prior to React 19, but not anymore.

Also added a solid component since the error only occurred when using two frameworks that share the same file extension.

One caveat: if windows is the targeted platform, react-component-production.test.js is not ran. On windows it seems to ignore overriding NODE_ENV. Perhaps I'm missing something obvious here.

@ascorbic The tests are working again! It turns out the issue was caused by the fixtures importing the development build of React while rendering with the production build. This behavior rendered fine prior to React 19, but not anymore.

Also added a solid component since the error only occurred when using two frameworks that share the same file extension.

One caveat: if windows is the targeted platform, react-component-production.test.js is not ran. On windows it seems to ignore overriding NODE_ENV. Perhaps I'm missing something obvious here.

to be honest it would be ideal if it was easier to test for multiple versions of a library but i think that's beyond the scope now

to be honest it would be ideal if it was easier to test for multiple versions of a library but i think that's beyond the scope now

You can, actually, and it's easy. In the fixtures, instead of using workspace:*, install the react version that you need to test.

to be honest it would be ideal if it was easier to test for multiple versions of a library but i think that's beyond the scope now

You can, actually, and it's easy. In the fixtures, instead of using workspace:*, install the react version that you need to test.

But this requires a copy of the fixtures no? I was looking for a way to do it on test level

Yeah, in this case, you should create two fixtures. And you'll have one test file where we load both fixtures (a test case for fixture). That's the expected way to go, we do that all the time :)

Yeah, in this case, you should create two fixtures. And you'll have one test file where we load both fixtures (a test case for fixture). That's the expected way to go, we do that all the time :)

Yeah unfortunately this doesn't really work because node:test creates an isolated worker per test file, thus it caches the react import and there's no way to clear the cache yet when using ESM 😔

I was thinking of using npm aliases but then you need a different import statement in fixtures as well.

I believe there's a misunderstanding. I'll see if I can help when I have time

I've done a similar change in #12948 before noticing this. Sorry about that.

I couldn't quite figure out how to fix the test though, but it seems like you did, so I think it's still valuable if we can get that merged in. #12686 (comment)

I've done a similar change in #12948 before noticing this. Sorry about that.

I couldn't quite figure out how to fix the test though, but it seems like you did, so I think it's still valuable if we can get that merged in. #12686 (comment)

Don't worry, no hard feelings. I was able to "fix" the tests by copying existing react 18 tests and using separate fixtures for react 18 and react 19. It's not ideal.

I don't mind implementing an alternative solution. If you or @ematipico could have a quick look, that'd be great. Could hop on discord too if you want me to show what's the issue.

I think it's ok to drop the react 18 tests if it's making things harder, or if it helps simplify the setup. We also support react 17 but we don't really test it anymore. Should probably release a new major with only the latest react major at some point.