🐛 [bug:i18n] Some issues with astro.config.{*s} and astro:i18n

[JakiChen]

Astro Info

Astro                    v5.1.8
Node                     v22.12.0
System                   macOS (x64)
Package Manager          yarn
Output                   server
Adapter                  @astrojs/vercel
Integrations             astro-robots
                         @astrojs/sitemap
                         @storyblok/astro

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Astro ( astro.config.{*s} ) Configuration

i18n: {
      locales: ['zh-CN', 'zh-HK', { path: 'english', codes: ['en-GB', 'en-US', 'en'] }],
      defaultLocale: 'zh-CN',
      domains: {
          'en-GB':'https://example.com.us'
    }
},

Details (Reference Configuration)

import { defineConfig } from 'astro/config';

import { env, vite, paths } from './config';
import { favicons, robots, sitemap } from './config/integrations';

import storyblok from '@storyblok/astro';

export default defineConfig({
  // site: env.SITE_URL,
  trailingSlash: 'ignore',
  //
  ...(await import('./config/vercel/server')).default,
  //
  integrations: [
    // favicons,
    robots,
    sitemap,
    storyblok({
      accessToken: env.STORYBLOK_TOKEN,
      apiOptions: {
        cache: {
          clear: 'auto',
          type: 'memory',
        },
        region: 'eu',
      },
      bridge: import.meta.env.DEV,
      livePreview: false,
      componentsDir: 'src/components',
      components: {},
    }),
  ],
  //
  outDir: './build',
  compressHTML: import.meta.env.PROD,
  scopedStyleStrategy: 'attribute',
  vite,
  build: {
    format: 'file',
    inlineStylesheets: 'never',
    assets: paths.build.assets,
  },
  image: {
    domains: ['a.storyblok.com'],
  },
  //
  i18n: {
    locales: ['zh-CN', 'zh-HK', { path: 'english', codes: ['en-GB', 'en-US', 'en'] }],
    defaultLocale: 'zh-CN',
    domains: {
      'english':'https://example.com.us'
    }
  },
});

Figures

(Figure 1)

(Figure 2)

( Figure 3)

Issues in astro.config.{*s}

Preview Give feedback

1. When i18n configuration is not provided, the type of the attribute "i18n" is reported to be incompatible. #13018
   needs triage +1
2. ! The locale en-US key in the i18n.domains record doesn't exist in the i18n.locales array. #13020
   needs triage +1
3. When the path value （english） is used as the key: the object literal can only specify known properties, and english is not in the type Partial<Record<"zh-CN" | "en-GB" | "en" | "zh-HK" | "en-US", string>>, but it can solve issue 2 #13019
   needs triage +1

Astro (astro:i18n) runtime

I am trying to extend some interfaces to AstroGlobal for dynamic generation of structured data.

Object.defineProperties(Astro, {
    canonicalURL: {
        value: new URL(pathname, Astro.site),
    },
    pathHasLocale: {
        value: pathname.startsWith(`/${currentLocale}/`) || pathHasLocale(pathname),
    },
});

Example 1: Dynamically generate itemListElement of BreadcrumbList

import type { AstroGlobal } from 'astro';
import type { ListItem } from 'schema-dts';
import { getTranslations, type Language } from '../../translations';

export const breadcrumbListElement = (context: AstroGlobal): ListItem[] => {
    const { site, url, props, currentLocale, pathHasLocale } = context;
    const i18n: { [key: string]: string } = getTranslations(currentLocale as Language);

    const segments = url.pathname.split('/').filter(Boolean);
    const items: ListItem[] = [];

    const addItem = (position: number, name: string, item?: string) => {
        items.push({ '@type': 'ListItem', position, name, item });
    };

    if (!pathHasLocale) {
        addItem(1, i18n.home, segments.length > 0 ? site?.toString() : undefined);
    }

    segments.forEach((segment, index) => {
        const name =
            index === 0 && pathHasLocale ? i18n.home : (i18n[segment] ?? props.title ?? segment);
        const item =
            index !== segments.length - 1
                ? `${site}${segments.slice(0, index + 1).join('/')}`
                : undefined;

        addItem(index + (pathHasLocale ? 1 : 2), name, item);
    });

    return items;
};

Issues in asto:i18n

Preview Give feedback

1. pathHasLocale(path:string) **Should be improved 1**: should not be limited to the determination of segment, should be combined with the attributes related to the __ASTRO_INTERNAL_I18N_CONFIG__ object (such as base) #13021
   needs triage +1
2. pathHasLocale(path:string) **Should be improved 2**: When i18n is not configured in the file astro.config.{*s}, it should not throw an error, but should be more friendly and gentle, and directly return false: because at this time pathname is treated as a regular path. #13022
   needs triage +1

What's the expected result?

Main tasks

• Fix bug - Issues in astro.config.{*s}

Minor tasks

• Improve - Issues in asto:i18n: function pathHasLocale(path:string)

Link to Minimal Reproducible Example

https://github.com/withastro/astro/tree/main/examples/basics

Participation

• I am willing to submit a pull request for this issue.

[ascorbic]

Please don't create sub-issues. Can you share a reproduction and a succinct description of the issue that you are reporting. This umbrella issue is hard to follow, and it's unclear what is the exact problem.

[github-actions]

Hello @JakiChen. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.