Missing reactivity of HydrateAtoms

[rtritto]

With the original implementation (https://jotai.org/docs/guides/initialize-atom-on-render), I created:

// HydrateAtoms.tsx
import type { Component, JSXElement } from 'solid-js'
import { useHydrateAtoms } from 'solid-jotai/utils'

/** @doc https://jotai.org/docs/guides/initialize-atom-on-render */
const HydrateAtoms: Component<{
  initialValues: Parameters<typeof useHydrateAtoms>[0]
  children: JSXElement
}> = (props) => {
  // initialising on state with prop on render here
  useHydrateAtoms(props.initialValues)
  return props.children
}

export default HydrateAtoms

Using eslint-plugin-solid, I get:

  11:10  warning  The reactive variable 'props.children' should be used within JSX, a tracked scope (like createEffect), or inside an event handler function, or else changes will be ignored  solid/reactivity

How should it be fixed?

[rtritto]

This can be fixed with:

- return props.children
+ return <>{props.children}</>

Is it correct?