Hypre build failure with xsdk+rocm
#227
Assignees
Comments
|
tried the following change and still get errors: diff --git a/var/spack/repos/builtin/packages/xsdk/package.py b/var/spack/repos/builtin/packages/xsdk/package.py
index b52d692b78..629f240a8f 100644
--- a/var/spack/repos/builtin/packages/xsdk/package.py
+++ b/var/spack/repos/builtin/packages/xsdk/package.py
@@ -109,8 +109,8 @@ class Xsdk(BundlePackage, CudaPackage, ROCmPackage):
variant("hiop", default=True, description="Enable hiop build")
variant("raja", default=(sys.platform != "darwin"), description="Enable raja for hiop, exago")
- xsdk_depends_on("hypre@develop+superlu-dist+shared", when="@develop", cuda_var="cuda")
- xsdk_depends_on("[email protected]+superlu-dist+shared", when="@1.0.0", cuda_var="cuda")
+ xsdk_depends_on("hypre@develop+superlu-dist+shared", when="@develop", cuda_var="cuda", rocm_var="rocm")
+ xsdk_depends_on("[email protected]+superlu-dist+shared", when="@1.0.0", cuda_var="cuda", rocm_var="rocm")
xsdk_depends_on("[email protected]+superlu-dist+shared", when="@0.8.0", cuda_var="cuda")
xsdk_depends_on("[email protected]+superlu-dist+shared", when="@0.7.0", cuda_var="cuda") |
|
We need to merge PR hypre-space/hypre#869 into hypre's master to make Related: #225 |
|
Oops, now I notice that the issue here was I'm wondering why SuperLU_dist is defining GPU stuff while this build isn't supposed to use GPUs: |
Ah, sorry for creating a duplicate issue. We can close this one [if needed]
Yeah - Ideally we should have both Current mode of superlu-dist+rocm hypre~rocm is a carry-over from prior xsdk release. |
Ah ok, I see! We will have that with the hypre PR I mentioned |
|
Ok - adding 'hypre+rocm' to '[email protected]' now [so this is the mode that will get tested]. |
@victorapm , I tried building with the above change [i.e use Hm - maybe its an issue with hypre [or superlu-dist?] spec in spack wrt rocm dependencies.. |
|
Thanks for the feedback! hypre links to rocblas with the rocm build. It seems superlu_dist needs hipblas? We could add this as an additional LDFLAGS maybe? |
|
This gets the diff --git a/var/spack/repos/builtin/packages/hypre/package.py b/var/spack/repos/builtin/packages/hypre/package.py
index ede99fafcc..5364a3bb73 100644
--- a/var/spack/repos/builtin/packages/hypre/package.py
+++ b/var/spack/repos/builtin/packages/hypre/package.py
@@ -24,7 +24,7 @@ class Hypre(AutotoolsPackage, CudaPackage, ROCmPackage):
test_requires_compiler = True
version("develop", branch="master")
- version("2.30.0", branch="master")
+ version("2.30.0", branch="dsuperlu")
version("2.29.0", sha256="98b72115407a0e24dbaac70eccae0da3465f8f999318b2c9241631133f42d511")
version("2.28.0", sha256="2eea68740cdbc0b49a5e428f06ad7af861d1e169ce6a12d2cf0aa2fc28c4a2ae")
version("2.27.0", sha256="507a3d036bb1ac21a55685ae417d769dd02009bde7e09785d0ae7446b4ae1f98")
@@ -108,6 +108,7 @@ def patch(self): # fix sequential compilation in 'src/seq_mv'
depends_on("rocthrust", when="+rocm")
depends_on("rocrand", when="+rocm")
depends_on("rocprim", when="+rocm")
+ depends_on("hipblas", when="+rocm")
depends_on("umpire", when="+umpire")
depends_on("caliper", when="+caliper")
@@ -258,7 +259,7 @@ def configure_args(self):
configure_args.append("--disable-cub")
if "+rocm" in spec:
- rocm_pkgs = ["rocsparse", "rocthrust", "rocprim", "rocrand"]
+ rocm_pkgs = ["rocsparse", "rocthrust", "rocprim", "rocrand", "hipblas"]
rocm_inc = ""
for pkg in rocm_pkgs:
if "^" + pkg in spec: |
|
Looks like this issue will be with all pkgs that use superlu-dist. @xiaoyeli can this dependency [on hipblas.h] be avoided from public include files? [assuming its primarily required in superlu-dist sources] |
|
Maybe we need to incorporate this into hypre's configure/CMakeLists for folks not building it via spack. The spack fix wouldn't be necessary then (although much appreciated!) |
This sounds great if possible :) |
|
@xiaoyeli I get the following with petsc [this warning breaks the build] I guess this should go into a "new" issue.. |
Fixed in #236 (comment) |
The updated change(for hypre+rocm with superlu-dist+rocm) is now at spack/spack#40980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I thought this build was successful last week [but don't know for sure]
ref:
./bin/spack install -j64 xsdk+rocm amdgpu_target=gfx90aspack-build-out.txt
The text was updated successfully, but these errors were encountered: