Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Top-level Store removal not in v3 migration guide #2733

Open
QuLogic opened this issue Jan 20, 2025 · 1 comment
Open

DOC: Top-level Store removal not in v3 migration guide #2733

QuLogic opened this issue Jan 20, 2025 · 1 comment
Labels
documentation Improvements to the documentation help wanted Issue could use help from someone with familiarity on the topic

Comments

@QuLogic
Copy link
Contributor

QuLogic commented Jan 20, 2025

Describe the issue linked to the documentation

I've found that imagecodecs fails to build with Zarr 3 cgohlke/imagecodecs#123 due to their use of zarr.MemoryStore.

While I linked to the migration guide, a search through it does not have any mention of MemoryStore. I think they should be using zarr.storage.MemoryStore instead, but there's no note there and I don't know if that was available in v2 or not.

Suggested fix for documentation

All zarr.*Store removals should be mentioned in the v3 migration guide along with their replacements.
@QuLogic QuLogic added documentation Improvements to the documentation help wanted Issue could use help from someone with familiarity on the topic labels Jan 20, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Jan 20, 2025

thanks for the report, and sorry for the inconvenience caused here. we should definitely update the guide as you suggest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements to the documentation help wanted Issue could use help from someone with familiarity on the topic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuLogic @d-v-b