Add timeout on secure websocket receive method
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't currently add you as a reviewer @nshaaban-cPacket, but I've send you an invite to change this. If you've got time I would feel safer if you would review the PR, otherwise I would just trust mine and Aarons tests. |
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 87.87% 87.58% -0.30%
==========================================
Files 20 20
Lines 1633 1643 +10
==========================================
+ Hits 1435 1439 +4
- Misses 198 204 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #133 by adding a timeout on the Websocket's receive method. This way the lock on the client isn't held until the next message is received.