MERGE PROFILE PAGE: #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riblanc
force-pushed
the
ri/profile_page
branch
from
4f46c1c to
6ad173e
Compare
Add an avatar component, and use it on settings component.
Add a really basic profile page and component.
Add options on WrapperOptions on api plugin.
Add the serveStaticModule on appModule, in order to serves avatars folder
Rewrite createOrUpdate user method.
Add an upload avatar route, in order to upload files on avatars files.
Add upload avatar from profile or from settings pages.
Add a rule ignoring the "avatars" folder.
Added a global exception filter to return a 404 error when retrieving a non-existent image.
Provide a way to change username, catching already taken usernames. Generate a suffix to already exist username during user creation (first login)
Add a Username component, to provide an easy way to display or custom username. Fix navigator cache when posting a new image with the same mime/type as the older one by adding a suffix based on current timestamp.
Fix the ability to change our username through someone else profile page.
Add a basic status module with his service.
Update the user controller and chat gateway, in order to implement the basic status logic.
The get(/user/:id) will not return the user and his current status.
The gateway will notify each connected clients with an event `user:${id}:status` with the current status of a player connecting or disconnecting.
riblanc
force-pushed
the
ri/profile_page
branch
from
3428477 to
666dea1
Compare
AdrianWeaver
reviewed
Oct 6, 2023
AdrianWeaver
reviewed
Oct 6, 2023
AdrianWeaver
reviewed
Oct 6, 2023
AdrianWeaver
reviewed
Oct 6, 2023
AdrianWeaver
reviewed
Oct 6, 2023
AdrianWeaver
reviewed
Oct 6, 2023
AdrianWeaver
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Hey I asked a few questions on this PR. It's mostly in order to understand what is done even though it seems to be working as expected.
If you have time to explain here or when we're live I would appreciate.
I did not review the front files as I do not feel at ease to do it.
Add user status to profile page.
riblanc
force-pushed
the
ri/profile_page
branch
from
666dea1 to
c819538
Compare
riblanc
changed the title
Update username validation rules for alphanumeric with hyphens and underscores.
riblanc
force-pushed
the
ri/profile_page
branch
from
a73c69c to
6b45db5
Compare
Add the blur to all profiles (and not only ours)
Elena-Lou
requested changes
Oct 6, 2023
AdrianWeaver
previously approved these changes
Oct 6, 2023
There was a problem hiding this comment.
I'm approving the back files.
When you're good with the front you can merge @Elena-Lou
Elena-Lou
requested changes
Oct 6, 2023
Remove useless logs. Co-authored-by: Elena-Lou <[email protected]>
Elena-Lou
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic profile page including:
Avatar upload.
Ability to change username.
Add a suffix when username already taken.
Add basic status management.
Close #66
Close #56