Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUDA On Windows #4309

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

CUDA On Windows #4309

wants to merge 4 commits into from

Conversation

WeiqunZhang
Copy link
Member

@WeiqunZhang WeiqunZhang commented Jan 23, 2025 •
edited
Loading

Implement various workarounds for CUDA on Windows.

  • Redo some kernel launch macros because they do not work in function templates.
  • Work around the limitation that the extended lambda does not work inside if constexpr blocks.
  • Inline some function templates to avoid function mismatch.
  • Remove some SFINAE that do not work for CUDA on Windows.
  • Replace small with sml because a windows system header has #define small char.
  • Implement isnan and isinf for device code.
  • Disable probinit.
  • Skip DeviceGlobal and single precision linear solver tests because of certain limitations.

Add CUDA On Windows CI with cuda toolkit installed by Jimver/cuda-toolkit.

@WeiqunZhang
CUDA On Windows
21e7ab3 
Implement various workarounds for CUDA on Windows.
  - Redo some kernel launch macros because they do not work in function templates.
  - Extended lambda does not work inside if constexpr blocks.
  - Inline some function templates to avoid function mismatch.
  - Remove some static asserts that do not work for CUDA on Windows.
  - Replace small with sml because a windows system header has `#define small char`.
  - Disable probinit.
  - Disable DeviceGlobal test.

Add CUDA On Windows CI with cuda toolkit installed by Jimver/cuda-toolkit.
@WeiqunZhang WeiqunZhang marked this pull request as ready for review January 23, 2025 23:16
@WeiqunZhang WeiqunZhang requested a review from ax3l January 23, 2025 23:16
@WeiqunZhang WeiqunZhang mentioned this pull request Jan 23, 2025
Open
@WeiqunZhang WeiqunZhang linked an issue Jan 23, 2025 that may be closed by this pull request
AMReX Build Errors Windows Visual Studio 2022 (CUDA Enabled) - With Latest Development branch Pull #3972
Open
@WeiqunZhang WeiqunZhang mentioned this pull request Jan 23, 2025
Open
@WeiqunZhang WeiqunZhang force-pushed the win-cuda branch 4 times, most recently from 581a9e4 to d738812 Compare January 24, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l Awaiting requested review from ax3l

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AMReX Build Errors Windows Visual Studio 2022 (CUDA Enabled) - With Latest Development branch Pull
1 participant
@WeiqunZhang