Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory sanitizer CI #2254

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Add memory sanitizer CI #2254

merged 5 commits into from
Jan 22, 2025

Conversation

vrabaud
Copy link
Collaborator

@vrabaud vrabaud commented Jul 11, 2024

msan tests take 10 minutes. We might want a different file and only run it once merged.

@vrabaud vrabaud force-pushed the msan branch 4 times, most recently from 8fcff4d to 6e3ed83 Compare December 10, 2024 12:16
@vrabaud vrabaud force-pushed the msan branch 2 times, most recently from be16816 to b0f43f9 Compare January 3, 2025 17:03
@vrabaud vrabaud force-pushed the msan branch 12 times, most recently from 4462fff to d8e7ea8 Compare January 13, 2025 16:23
@vrabaud vrabaud force-pushed the msan branch 9 times, most recently from c1b4fa6 to 9e5ec28 Compare January 17, 2025 14:45
@vrabaud vrabaud force-pushed the msan branch 2 times, most recently from 4325af5 to 6395939 Compare January 17, 2025 15:14
@vrabaud vrabaud requested a review from jzern January 17, 2025 15:15
tests/gtest/avifallocationtest.cc Outdated Show resolved Hide resolved
@vrabaud
Copy link
Collaborator Author

vrabaud commented Jan 21, 2025

I moved the CI to its own file and it is only triggered on push due to its slowness (25 minutes)

@vrabaud vrabaud marked this pull request as ready for review January 21, 2025 15:25
@vrabaud vrabaud requested a review from jzern January 21, 2025 15:25
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for adding the MemorySanitizer workflow!

tests/gtest/avifallocationtest.cc Outdated Show resolved Hide resolved
.github/workflows/ci-unix-static-sanitized-memory.yml Outdated Show resolved Hide resolved
.github/workflows/ci-unix-static-sanitized-memory.yml Outdated Show resolved Hide resolved
.github/workflows/ci-unix-static-sanitized-memory.yml Outdated Show resolved Hide resolved
.github/workflows/ci-unix-static-sanitized-memory.yml Outdated Show resolved Hide resolved
@vrabaud vrabaud merged commit 2985845 into AOMediaCodec:main Jan 22, 2025
26 checks passed
@vrabaud vrabaud deleted the msan branch January 22, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants