-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory sanitizer CI #2254
Merged
Merged
Add memory sanitizer CI #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
reviewed
Jul 11, 2024
vrabaud
force-pushed
the
msan
branch
4 times, most recently
from
December 10, 2024 12:16
8fcff4d
to
6e3ed83
Compare
vrabaud
force-pushed
the
msan
branch
2 times, most recently
from
January 3, 2025 17:03
be16816
to
b0f43f9
Compare
wantehchang
reviewed
Jan 3, 2025
vrabaud
force-pushed
the
msan
branch
12 times, most recently
from
January 13, 2025 16:23
4462fff
to
d8e7ea8
Compare
vrabaud
force-pushed
the
msan
branch
9 times, most recently
from
January 17, 2025 14:45
c1b4fa6
to
9e5ec28
Compare
vrabaud
force-pushed
the
msan
branch
2 times, most recently
from
January 17, 2025 15:14
4325af5
to
6395939
Compare
jzern
approved these changes
Jan 17, 2025
I moved the CI to its own file and it is only triggered on push due to its slowness (25 minutes) |
wantehchang
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for adding the MemorySanitizer workflow!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msan tests take 10 minutes. We might want a different file and only run it once merged.