-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/Added detailed AI Image Generation Model Documentation #244
base: main
Are you sure you want to change the base?
Docs/Added detailed AI Image Generation Model Documentation #244
Conversation
This PR adds detailed Documnetation for #242 |
Hey @ParagGhatage In the documentation, the model you provided is 3.8GB: After that, we need to copy the entire folder to image_generation. This model is consuming a significant amount of storage. Its size may lead to a considerable decline in performance if we use it as it is. Additionally, I couldn't find any documentation related to this specific model in the ONNX Model Zoo. |
Hey @Jibesh10101011 . Its doesnt consume that much for actual image generation task. We have tested it for different performace issues. |
@Jibesh10101011 |
Then overall size of the Project become more than 5 to 6 GB |
And also if We use Docker then it will come to 8 to 9 GB |
we used fast api for intergration have a look @Jibesh10101011 HAVE A LOOK |
ONNX doesnt work for all the models. Be assured , it will not degrade performance. And about multi-device compatibility, it will be future optimization for this feature. |
It is not about being good; it's about system performance and compatibility. |
Our current docker setup doesnt work for local file system. So, it will be point to consider when we find a way to make model more efficient. |
But it is violating the architecture of the PictoPy backend |
It works run it via docker compose everything works now , I have completed that issue some days ago |
What do you mean? |
I mean this |
Even without ONNX, the feature will work fine because the underlying logic and models are compatible with the current backend setup. ONNX is primarily a performance optimization tool, and its absence won't hinder the core functionality. and we made sure to do our testing |
Like I said, ONNX isnt useful for all models. PictoPy's current ONNX models are performing below average for image tagging. Whats point of ONNX model if it cant have even 30% Accuracy? |
You can not say this , Every one used different type of Machine , OS and also all devices configuration are not same |
bro @Jibesh10101011 i did my testing as my laptop have the feature to analyze everything while limiting the performance of my laptop |
When it comes to ONNX, it's about compatibility, not accuracy. If the model you provide doesn't work on all devices, then for those devices, the accuracy becomes zero. However, with ONNX, you can ensure that the model runs on any device, and also models size should be as minimized as well. |
@Jibesh10101011 While ONNX enhances compatibility and minimizes model size, the immediate focus is to deliver functionality rather than universal device coverage. The current approach ensures the feature works on a significant range of devices, prioritizing usability for the majority. Future iterations can incorporate ONNX for broader compatibility and size optimization without delaying initial user access to the feature. |
|
This thing never be said like this , whatever you are saying if all models can be ac
In the future, there is no certainty whether ONNX will continue to be supported. and also the most important thing to note is that your model size is 4.0 GB |
Stable Diffusion is compatible with most major operating systems, including Windows, macOS, and Linux. However, the installation process and system requirements may vary depending on the OS. |
Description:
This PR introduces the following updates:
README.md
to guide users toward more detailed information about the AI models used in the project.README.md
file, directing users to a new documentation file (docs\AI-Models\Image-Generation\stable_deffusion.md
) for in-depth setup and configuration details of the AI models.Changes:
docs\AI-Models\Image-Generation\stable_deffusion.md
.-Added detailed model documentation for AI image generation.
Why this is important:
This update provides clearer guidance to users on where to find comprehensive information about the AI models integrated into the project. It also consolidates helpful resources to make the setup process smoother for contributors and users.
Changes to Documentation:
README.md
was updated with a new "Model Documentation" section and additional external links.