-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jth mypy changes #258
jth mypy changes #258
Conversation
jobs: | ||
call-secrets-analysis-workflow: | ||
# Docs: https://github.com/ASFHyP3/actions | ||
uses: ASFHyP3/actions/.github/workflows/reusable-secrets-analysis.yml@v0.14.0 | ||
uses: ASFHyP3/actions/.github/workflows/reusable-secrets-analysis.yml@v0.13.2 | ||
|
||
call-ruff-workflow: | ||
# Docs: https://github.com/ASFHyP3/actions | ||
uses: ASFHyP3/actions/.github/workflows/reusable-ruff.yml@v0.14.0 | ||
uses: ASFHyP3/actions/.github/workflows/reusable-ruff.yml@v0.13.2 | ||
|
||
call-mypy-workflow: | ||
# Docs: https://github.com/ASFHyP3/actions | ||
uses: ASFHyP3/actions/.github/workflows/[email protected] | ||
# TODO: update version tag after actions release | ||
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will all be 14.0 after the release right? We have to do the actions release first anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I wanted those workflows (especially the mypy workflow) to run on our hyp3-isce2
PRs so I could make sure I wasn't breaking anything. But, I'd be fine with reverting this change after we do the actions release.
Changes:
v0.14.0
(not yet released)str()
casts (I confirmed withreveal_type
that mypy already correctly infers those types asstr
)AttributeError
toValueError
, becauseAttributeError
specifically refers to Python object attributes, which isn't how we're using exceptions in this case.