Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ASFHyP3/actions from 0.14.0 to 0.15.0 #262

Merged
merged 4 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
jobs:
call-changelog-check-workflow:
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-changelog-check.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-changelog-check.yml@v0.15.0

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
2 changes: 1 addition & 1 deletion .github/workflows/create-jira-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@

jobs:
call-create-jira-issue-workflow:
uses: ASFHyP3/actions/.github/workflows/reusable-create-jira-issue.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-create-jira-issue.yml@v0.15.0
secrets:
JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }}
JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }}
JIRA_API_TOKEN: ${{ secrets.JIRA_API_TOKEN }}
JIRA_PROJECT: ${{ secrets.JIRA_PROJECT }}
JIRA_FIELDS: ${{ secrets.JIRA_FIELDS }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
2 changes: 1 addition & 1 deletion .github/workflows/labeled-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@
jobs:
call-labeled-pr-check-workflow:
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-labeled-pr-check.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-labeled-pr-check.yml@v0.15.0

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
2 changes: 1 addition & 1 deletion .github/workflows/release-checklist-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
call-release-workflow:
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-release-checklist-comment.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-release-checklist-comment.yml@v0.15.0
permissions:
pull-requests: write
secrets:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
jobs:
call-release-workflow:
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-release.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-release.yml@v0.15.0
with:
release_prefix: HyP3 ISCE2
secrets:
USER_TOKEN: ${{ secrets.TOOLS_BOT_PAK }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
6 changes: 3 additions & 3 deletions .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
jobs:
call-secrets-analysis-workflow:
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-secrets-analysis.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-secrets-analysis.yml@v0.15.0

call-ruff-workflow:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-ruff.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-ruff.yml@v0.15.0

call-mypy-workflow:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.15.0

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
2 changes: 1 addition & 1 deletion .github/workflows/tag-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
jobs:
call-bump-version-workflow:
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-bump-version.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-bump-version.yml@v0.15.0
with:
user: tools-bot
email: [email protected]
secrets:
USER_TOKEN: ${{ secrets.TOOLS_BOT_PAK }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions Job or Workflow does not set permissions
6 changes: 3 additions & 3 deletions .github/workflows/test-and-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@
jobs:
call-pytest-workflow:
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-pytest.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-pytest.yml@v0.15.0
with:
local_package_name: hyp3_isce2
python_versions: >-
["3.10", "3.11"]

call-version-info-workflow:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium test

Actions Job or Workflow does not set permissions
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-version-info.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-version-info.yml@v0.15.0
with:
python_version: "3.10"

call-docker-ghcr-workflow:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium test

Actions Job or Workflow does not set permissions
needs: call-version-info-workflow
# Docs: https://github.com/ASFHyP3/actions
uses: ASFHyP3/actions/.github/workflows/reusable-docker-ghcr.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-docker-ghcr.yml@v0.15.0
with:
version_tag: ${{ needs.call-version-info-workflow.outputs.version_tag }}
release_branch: main
Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -111,3 +111,7 @@ warn_redundant_casts = true
warn_unreachable = true
strict_equality = true
check_untyped_defs = true
install_types = true
non_interactive = true
pretty = true
disable_error_code = ["import-untyped"]
4 changes: 2 additions & 2 deletions src/hyp3_isce2/burst.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
import asf_search
import numpy as np
import requests
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1
from isceobj.TopsProc.runMergeBursts import multilook
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1 # type: ignore[import-not-found]
from isceobj.TopsProc.runMergeBursts import multilook # type: ignore[import-not-found]
from lxml import etree
from shapely import geometry

Expand Down
2 changes: 1 addition & 1 deletion src/hyp3_isce2/insar_tops.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from shutil import copyfile, make_archive

from hyp3lib.util import string_is_true
from isceobj.TopsProc.runMergeBursts import multilook
from isceobj.TopsProc.runMergeBursts import multilook # type: ignore[import-not-found]
from s1_orbits import fetch_for_scene

from hyp3_isce2 import packaging, slc, topsapp
Expand Down
4 changes: 2 additions & 2 deletions src/hyp3_isce2/insar_tops_burst.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
from shutil import copyfile, make_archive
from typing import Optional

import isce # noqa
import isce # noqa: F401
from burst2safe.burst2safe import burst2safe
from hyp3lib.util import string_is_true
from isceobj.TopsProc.runMergeBursts import multilook
from isceobj.TopsProc.runMergeBursts import multilook # type: ignore[import-not-found]
from osgeo import gdal
from s1_orbits import fetch_for_scene

Expand Down
26 changes: 13 additions & 13 deletions src/hyp3_isce2/merge_tops_bursts.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,24 @@

import asf_search
import isce
import isceobj
import isceobj # type: ignore[import-not-found]
import lxml.etree as ET
import numpy as np
from contrib.Snaphu.Snaphu import Snaphu
from contrib.Snaphu.Snaphu import Snaphu # type: ignore[import-not-found]
from hyp3lib.util import string_is_true
from isceobj.Orbit.Orbit import Orbit
from isceobj.Planet.Planet import Planet
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1
from isceobj.TopsProc.runIon import maskUnwrap
from isceobj.TopsProc.runMergeBursts import mergeBox, mergeBursts2
from iscesys.Component import createTraitSeq
from iscesys.Component.ProductManager import ProductManager
from mroipac.filter.Filter import Filter
from mroipac.icu.Icu import Icu
from isceobj.Orbit.Orbit import Orbit # type: ignore[import-not-found]
from isceobj.Planet.Planet import Planet # type: ignore[import-not-found]
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1 # type: ignore[import-not-found]
from isceobj.TopsProc.runIon import maskUnwrap # type: ignore[import-not-found]
from isceobj.TopsProc.runMergeBursts import mergeBox, mergeBursts2 # type: ignore[import-not-found]
from iscesys.Component import createTraitSeq # type: ignore[import-not-found]
from iscesys.Component.ProductManager import ProductManager # type: ignore[import-not-found]
from mroipac.filter.Filter import Filter # type: ignore[import-not-found]
from mroipac.icu.Icu import Icu # type: ignore[import-not-found]
from osgeo import gdal
from shapely import geometry
from stdproc.rectify.geocode.Geocodable import Geocodable
from zerodop.geozero import createGeozero
from stdproc.rectify.geocode.Geocodable import Geocodable # type: ignore[import-not-found]
from zerodop.geozero import createGeozero # type: ignore[import-not-found]

import hyp3_isce2
import hyp3_isce2.burst as burst_utils
Expand Down
4 changes: 2 additions & 2 deletions src/hyp3_isce2/packaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ def get_product_name(
lons, lats = footprint.exterior.coords.xy

def lat_string(lat):
return ('N' if lat >= 0 else 'S') + f"{('%.1f' % np.abs(lat)).zfill(4)}".replace('.', '_')
return ('N' if lat >= 0 else 'S') + f'{("%.1f" % np.abs(lat)).zfill(4)}'.replace('.', '_')

def lon_string(lon):
return ('E' if lon >= 0 else 'W') + f"{('%.1f' % np.abs(lon)).zfill(5)}".replace('.', '_')
return ('E' if lon >= 0 else 'W') + f'{("%.1f" % np.abs(lon)).zfill(5)}'.replace('.', '_')

lat_lims = [lat_string(lat) for lat in [np.min(lats), np.max(lats)]]
lon_lims = [lon_string(lon) for lon in [np.min(lons), np.max(lons)]]
Expand Down
6 changes: 3 additions & 3 deletions src/hyp3_isce2/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
from pathlib import Path
from typing import Optional

import isceobj
import isceobj # type: ignore[import-not-found]
import numpy as np
from isceobj.Util.ImageUtil.ImageLib import loadImage
from iscesys.Component.ProductManager import ProductManager
from isceobj.Util.ImageUtil.ImageLib import loadImage # type: ignore[import-not-found]
from iscesys.Component.ProductManager import ProductManager # type: ignore[import-not-found]
from osgeo import gdal, osr


Expand Down
2 changes: 1 addition & 1 deletion tests/test_merge_tops_bursts.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from unittest.mock import patch

import asf_search
import isceobj # noqa: I100
import isceobj # type: ignore[import-not-found]
import lxml.etree as ET
import numpy as np
import pytest
Expand Down
2 changes: 1 addition & 1 deletion tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from pathlib import Path
from unittest.mock import patch

import isceobj # noqa
import isceobj # type: ignore[import-not-found]
import numpy as np
from osgeo import gdal

Expand Down
Loading