Skip to content

Commit

Permalink
Merge pull request #31 from ATFutures/cran1
Browse files Browse the repository at this point in the history
Cran feedback fixes, #13
  • Loading branch information
Robinlovelace authored Feb 5, 2019
2 parents 770cdcc + b698951 commit 6c67c0f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 10 deletions.
7 changes: 3 additions & 4 deletions R/ic_read.R
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,14 @@ ic_read <- function(file) {
#' @export
#' @examples
#' ic <- ical(ical_example)
#' ic_write(ic, "ic.ics")
#' ic_write(ic, file.path(tempdir(), "ic.ics"))
#' f <- system.file("extdata", "example.ics", package = "calendar")
#' identical(readLines("ic.ics"), readLines(f))
#' identical(readLines(file.path(tempdir(), "ic.ics")), readLines(f))
#' f <- system.file("extdata", "england-and-wales.ics", package = "calendar")
#' ics_df <- ic_read(f)
#' ic_write(ics_df, "ic.ics")
#' ic_write(ics_df, file.path(tempdir(), "ic.ics"))
#' # test similarity between files with diff tool like meld - from shell:
#' # meld ic.ics inst/extdata/england-and-wales.ics
#' file.remove("ic.ics")
ic_write <- function(ic, file) {
ic_char <- ic_character(ic)
writeLines(ic_char, file)
Expand Down
1 change: 0 additions & 1 deletion R/ical.R
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ ic_attributes_vec <- function(
#' ic <- ical(ical_example)
#' ic_character(ic)
#' identical(ical_example, ic_character(ic))
#' # ic_character(ic[c(1, 1), ]) # multiple events
ic_character <- function(ic) {
char_attributes <- paste(names(attributes(ic)$ical), attributes(ic)$ical, sep = ":")
char_events <- ic_char_event(ic)
Expand Down
1 change: 0 additions & 1 deletion man/ic_character.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions man/ic_write.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6c67c0f

Please sign in to comment.