-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve EOSdash. #417
base: feature/config-nested
Are you sure you want to change the base?
Improve EOSdash. #417
Conversation
e36c529
to
cc29506
Compare
Ready for review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very excited to check it out, can you upload footer.py as well?
ModuleNotFoundError: No module named 'akkudoktoreos.server.dash.footer'
src/akkudoktoreos/server/eos.py
Outdated
return {"status": "alive"} | ||
|
||
|
||
@app.put("/v1/config/value", tags=["config"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably merge leftover? /v1/config/value Has to be re-added in the future, currently broken. I would keep /v1/config/reset over .../update to better indicate it's effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
@rt("/") | ||
def get(): # type: ignore | ||
return Titled("EOS Dashboard", H1("Configuration"), config_table()) | ||
@app.get("/eosdash/demo") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the demo page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make EOSdash use UI components from MonsterUI to ease further development. - Add a first menu with some dummy pages and the configuration page. - Make the configuration scrollable. - Add a footer that displays connection status with EOS server Update EOS server: - Provide health endpoint for alive checking. - Move error message generation to extra module Signed-off-by: Bobby Noelte <[email protected]>
Sorry, test for EOSdash is definitively missing. Module added now. |
after starting eos on windows accessing http://localhost:8503/ i get the 404. access to eosdash does work (http://localhost:8504/) very nice. Documentation link should open in a new tab. |
Make EOSdash use UI components from MonsterUI to ease further development.
Update EOS server:
For feature branch: feature/config-nested.