Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EOSdash. #417

Open
wants to merge 1 commit into
base: feature/config-nested
Choose a base branch
from

Conversation

b0661
Copy link
Collaborator

@b0661 b0661 commented Jan 25, 2025

Make EOSdash use UI components from MonsterUI to ease further development.

  • Add a first menu with some dummy pages and the configuration page.
  • Make the configuration scrollable.
  • Add a footer that displays connection status with EOS server

Update EOS server:

  • Provide health endpoint for alive checking.
  • Move error message generation to extra module

For feature branch: feature/config-nested.

@b0661 b0661 force-pushed the add_eosapp branch 3 times, most recently from e36c529 to cc29506 Compare January 26, 2025 15:12
@b0661 b0661 requested review from NormannK and Lasall January 26, 2025 16:25
@b0661
Copy link
Collaborator Author

b0661 commented Jan 26, 2025

Ready for review and merge.

Copy link
Collaborator

@Lasall Lasall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very excited to check it out, can you upload footer.py as well?
ModuleNotFoundError: No module named 'akkudoktoreos.server.dash.footer'

return {"status": "alive"}


@app.put("/v1/config/value", tags=["config"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably merge leftover? /v1/config/value Has to be re-added in the future, currently broken. I would keep /v1/config/reset over .../update to better indicate it's effect.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@rt("/")
def get(): # type: ignore
return Titled("EOS Dashboard", H1("Configuration"), config_table())
@app.get("/eosdash/demo")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the demo page?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lasall, its a placeholder to fill in the graphics from @NormannK .

Make EOSdash use UI components from MonsterUI to ease further development.

- Add a first menu with some dummy pages and the configuration page.
- Make the configuration scrollable.
- Add a footer that displays connection status with EOS server

Update EOS server:

- Provide health endpoint for alive checking.
- Move error message generation to extra module

Signed-off-by: Bobby Noelte <[email protected]>
@b0661
Copy link
Collaborator Author

b0661 commented Jan 26, 2025

I'm very excited to check it out, can you upload footer.py as well? ModuleNotFoundError: No module named 'akkudoktoreos.server.dash.footer'

Sorry, test for EOSdash is definitively missing. Module added now.

@Lasall
Copy link
Collaborator

Lasall commented Jan 26, 2025

Looks pretty nice!
The content of the table (at least dark mode) is quite difficult to read.
Screenshot_20250126_183318

Also after initial load the footer shows "Footer" for 5sec.

@NormannK
Copy link
Collaborator

NormannK commented Jan 26, 2025

after starting eos on windows accessing http://localhost:8503/ i get the 404.
image

access to eosdash does work (http://localhost:8504/)

very nice.

Documentation link should open in a new tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants