Draft: Fix setup #3132
Open
Draft: Fix setup #3132
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundling failed due to a missing branch called download-flatpickr-locales reference.
Because of a missing imagemagick installation on my local machine the test suite failed. Imagemagick is a requirement to run AlchemyCMS so explicitely mention it in the README.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3132 +/- ##
==========================================
- Coverage 96.58% 96.58% -0.01%
==========================================
Files 236 236
Lines 6334 6360 +26
==========================================
+ Hits 6118 6143 +25
- Misses 216 217 +1 ☔ View full report in Codecov by Sentry. |
The guides already cover the relevant dependencies needed to run AlchemyCMS. As for contributing to AlchemyCMS or changing it, we don't currently have a dedicated place to list additional dependencies like chromedriver. I think the README would be a good spot to include that information, but it could also make its way into the guides if that makes more sense. What do you think? Shall we add a section on additional dependencies to the README or the guides?
tvdeyen
reviewed
Jan 7, 2025
| @@ -15,7 +15,7 @@ if ENV["DB"] == "mysql" || ENV["DB"] == "mariadb" | |||
| end | |||
| gem "pg", "~> 1.0" if ENV["DB"] == "postgresql" | |||
|
|
|||
| gem "alchemy_i18n", github: "AlchemyCMS/alchemy_i18n", branch: "download-flatpickr-locales" | |||
| gem "alchemy_i18n", github: "AlchemyCMS/alchemy_i18n", branch: "main" | |||
There was a problem hiding this comment.
This has already been fixed in latest main https://github.com/AlchemyCMS/alchemy_cms/blob/main/Gemfile#L18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes some issues happened during setting up the dev env