Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in Base.in methods and empty comprehension #954

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

samuelsonric
Copy link
Contributor

  • The in functions were not really causing problems, since Julia was defaulting to iterating over the container. However, it was creating method ambiguities (I caught it with Aqua).
  • In the function make_homomorphism the comprehension [row[i+=1] for _ in parts(X,c)] is creating a vector of type Any if parts(X, c) is empty.

@AlgebraicJulia AlgebraicJulia deleted a comment from github-actions bot Jan 22, 2025
@epatters epatters changed the title Fixed various bugs. Fix bugs in Base.in methods and empty comprehension Jan 22, 2025
@epatters epatters added the bug label Jan 22, 2025
Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Richard! I don't know how we got all those Base.in methods backward.

@epatters epatters merged commit 246b5fb into main Jan 22, 2025
11 of 12 checks passed
@epatters epatters deleted the richard_bugfixes branch January 22, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants