add vtkm check for Ascent default types #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We planned to include the default type cmake check for 0.9.2, now that we are using VTK-m 2.0, however it turns out the CMake logic isn't fully there yet. So we will need to wait for a new VTK-m patch release and address after 0.9.2 |
|
@nicolemarsaglia -- should we be able to get this in with VTK-m 2.1? |
|
Yeah, let me revisit this! |
|
@cyrush if you could just double check this I would appreciate it. Should be good, but this pr is very old and cmake changes scare me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check for VTKm_USE_DEFAULT_TYPES_FOR_ASCENT if this is set then in the vtkm build the use doubles is on and 64bit ids is off.
Needs a vtkm merge to reveal this flag