Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data on device test and example #1370

Merged
merged 8 commits into from
Sep 9, 2024
Merged

add data on device test and example #1370

merged 8 commits into from
Sep 9, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Aug 27, 2024

No description provided.

@cyrush
Copy link
Member Author

cyrush commented Aug 27, 2024

also fixes caliper defines

@cyrush cyrush requested a review from nicolemarsaglia August 27, 2024 18:26
nicolemarsaglia
nicolemarsaglia approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@nicolemarsaglia nicolemarsaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the two test cases!

@cyrush
Copy link
Member Author

cyrush commented Aug 29, 2024

Screenshot 2024-08-29 at 2 57 24 PM

My baselines (created w/o OpenMP) have a different scalar range vs what is running in CI.

@cyrush
Copy link
Member Author

cyrush commented Sep 6, 2024

I tried forcing serial, instead of openmp and I was not able to reproduce a difference. I think my initial baselines may have been bad.

@cyrush
Copy link
Member Author

cyrush commented Sep 6, 2024

Serial Windows:

GetGlobalRange
[-7.21645e-16..6.66134e-16]
GetGlobalRange
[-7.21644966006352e-16..6.66133814775094e-16]

Serial macOS:
GetGlobalRange
[-7.34722e-16..5.42145e-16]

GetGlobalRange
[-7.34721528284977e-16..5.42144806295629e-16]

OpenMP:

[ascent annotations enabled]
GetGlobalRange
[-7.31232e-16..6.52309e-16]
GetGlobalRange
[-7.31232e-16..6.52309e-16]

We are contouring at zero and there is some order of ops numeric difference.

Will switch to plotting radial which will have non zero data extents

@cyrush cyrush merged commit 91a7faf into develop Sep 9, 2024
22 checks passed
@cyrush cyrush deleted the task/2024_08_ascent_test_data_on_gpu branch September 9, 2024 21:40
@jfavre jfavre mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolemarsaglia nicolemarsaglia nicolemarsaglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrush @nicolemarsaglia