Adding actions for opening, flushing, and closing the logs #1442
+428
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks great! Can you add a note to the CHANGELOG.md file about these actions and a short section in the docs? We can think about the mpi relevant options We could also add support for The separate actions for log and echo thresholds are a good addition. |
|
Yes, I can add a note to the change log. I have a draft of the MPI relevant options but I don't have tests written for it yet so I didn't push them. I like the idea of adding the log threshold to the options for open_log. That should be a quick change so I will add that too. |
emily-howell
force-pushed
the
task/2025-1-14_add-actions-that-control-logging-options
branch
from
7d76632 to
08beb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently only adds some simple actions for opening, flushing, and closing the logs. I wonder if it would be useful to also add an action for modifying the logging threshold?