GitHub Enterprise Template - set storage account's minimum TLS version to TLSv1.2 #14284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-quickstarts
added
duplicate foldername
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Check these items before submitting a PR...
Contribution Guide
Best Practice Guide
Changelog
minimumTlsVersionto specify TLS 1.2 as the minimum TLS version of the created storage accountConsidering IETF officially deprecates TLS 1.0 and TLS 1.1 (RFC 8996 Deprecating TLS 1.0 and TLS 1.1) and Microsoft Azure will stop supporting TLS 1.0 and 1.1 on 2025-08-31, there is no valid reason to deploy a GitHub Enterprise Server to Azure with storage account that uses TLS 1.0 (default value) as the minimum TLS version.
This pull request adds a property to specify TLS 1.2 as the minimum TLS version of the created storage account.