Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firelands/Ragnaros: Improve various timings #29

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

stako
Copy link
Contributor

@stako stako commented Dec 18, 2024

Wrath of Ragnaros

  • Added initial cast, always 5-6 seconds into the encounter
  • Has a 25-26 second cooldown - remains the same for both normal & heroic
  • Sulfuras Smash will put Wrath of Ragnaros on a 10 second cooldown unless it's already on cooldown for a longer duration

As the 1st one comes in at ~5 seconds & it's got a ~25 second cooldown, we would expect the 2nd one to come in at ~30 seconds (1, 2, 3)

However, Ragnaros will typically begin casting Sulfuras Smash at ~30 seconds (2.5s cast time). This will cause Wrath of Ragnaros to be cast about 10 seconds later (1, 2, 3)

Using 12.5 seconds instead of 10 because we need account for Sulfuras Smash's cast time. (The Sulfuras Smash trigger is using SPELL_CAST_START, not SPELL_CAST_SUCCESS)

Phase 4 Callback

  • This was triggering a Win call on normal mode which is no longer needed since we've got the encounter ID's now

Lava Waves & Molten Seed

  • More accurate timings

@funkydude funkydude merged commit d2ac2f8 into BigWigsMods:master Dec 18, 2024
1 check passed
@stako stako deleted the ragnaros branch December 18, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants