Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algalon phase punch timer fix #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amotosouoc
Copy link

Algalon cancels his phase punch timer and starts a new one of 15s once it reaches last phase, the next phase punches are all on 10s timers.

…e it reaches last phase, the next phase punches are all on 10s timers.
@amotosouoc
Copy link
Author

This behavior only happens on the 25-man version

@funkydude
Copy link
Member

funkydude commented May 3, 2023

Why did you remove the UNIT_HEALTH function? It has nothing to do with the change you are proposing.

Could you provide a link to a combat log of this?

A full log from the Transcriptor addon would help us further analyze this fight also.

@amotosouoc
Copy link
Author

amotosouoc commented May 7, 2023

Here's a transcriptor log and wclog of the same kill:
Transcriptor.zip
https://classic.warcraftlogs.com/reports/NZHwja7XckKfxCgB#fight=25

The behavior can be seen in every log from 25man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants