Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor fhir calls to use POST #298

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

refactor fhir calls to use POST #298

wants to merge 29 commits into from

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Jan 16, 2025 •
edited
Loading

PULL REQUEST

Summary

Refactors our FHIR query layer to

  1. all use POST, since querying by the codes as constructed in the query building flow run into GET URL length limits
  2. construct concept type filters <> FHIR resource mapping more intelligently, rather than the code-system based logic that we used to have

Additional Information

Anything else the review team should know?

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Update documentation

fzhao99 and others added 22 commits January 16, 2025 16:19
@fzhao99
swap out use case hard codes for query table
da737ea
@fzhao99
refactor fhir queries to be posts
f2e6114
@fzhao99
use query table instead of hard coded use case
12f93a5
@fzhao99
fix git issues
bbd4274
@fzhao99
Merge branch 'main' into bob/use-query-table-over-use-cases
f8e21fd
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit hooks
fe9c63e
@fzhao99
Merge branch 'bob/run-custom-queries' into bob/refactor-fhir-calls-to…
7c71b5b 
…-post
@fzhao99
remove extra param
72f6150
@fzhao99
lint
28c79dd
@fzhao99
lint pt 2
dba2809
@fzhao99
merge
5b60e58
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit hooks
f04ea5f
@fzhao99
fix cancer selector
0840f3d
@fzhao99
fix cancer selector
b432817
@fzhao99
fix integration test
b7a3905
@fzhao99
handle deprecation fallback
37d49d4
@fzhao99
remove log
14e9481
@fzhao99
update postman collection
8f7ef1f
@fzhao99
Merge branch 'bob/use-query-table-over-use-cases' into bob/refactor-f…
ef7920e 
…hir-calls-to-post
@fzhao99
Merge branch 'bob/refactor-fhir-calls-to-post' of https://github.com/…
3c4802e 
…CDCgov/dibbs-query-connector into bob/refactor-fhir-calls-to-post
@fzhao99
change test in test
aa32d3b
@fzhao99
resolve pairing suggestinos
8bd0a35
Base automatically changed from bob/use-query-table-over-use-cases to main January 21, 2025 15:17
@fzhao99 fzhao99 changed the title refactor fhir calls to post refactor fhir calls to be post-based Jan 21, 2025
@fzhao99 fzhao99 changed the title refactor fhir calls to be post-based refactor fhir calls to use POST Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fzhao99