Johanna/6723 add destination disease columns upload table #6857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ination_disease_columns_upload_table
…ination_disease_columns_upload_table Merged with latest main
…ination_disease_columns_upload_table Merged with latest main
…ination_disease_columns_upload_table Merged with latest liquibase changes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
backend/src/main/java/gov/cdc/usds/simplereport/service/TestResultUploadService.java
Fixed
Show fixed
Hide fixed
| @Entity | ||
| @Slf4j | ||
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| @Builder |
Check notice
Code scanning / CodeQL
Use of default toString() Note
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @Entity | ||
| @Builder |
Check notice
Code scanning / CodeQL
Use of default toString() Note
BobanL
previously approved these changes
Nov 2, 2023
Comment on lines
153
to
164
| try { | ||
| processCovidResponse(covidSubmission.get()).ifPresent(uploadSummary::add); | ||
| } catch (CsvProcessingException | ExecutionException | InterruptedException e) { | ||
| log.error("Error processing csv in bulk result upload", e); | ||
| Thread.currentThread().interrupt(); | ||
| } | ||
| try { | ||
| processUniversalResponse(universalSubmission.get()).ifPresent(uploadSummary::add); | ||
| } catch (CsvProcessingException | ExecutionException | InterruptedException e) { | ||
| log.error("Error processing FHIR in bulk result upload", e); | ||
| Thread.currentThread().interrupt(); | ||
| } |
There was a problem hiding this comment.
These nested try catches are code smells, could you pull these out into their own private methods to resolve that?
|
Kudos, SonarCloud Quality Gate passed! |
|
I have addressed the feedback from Boban and Bob. New code is available in |
emyl3
approved these changes
Nov 2, 2023
johanna-skylight
deleted the
johanna/6723_add_destination_disease_columns_upload_table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKEND PULL REQUEST
Related Issue
Changes Proposed
UploadDiseaseDetailsand corresponding repository.TestResultUploadServiceinclude:saveSubmissionToDbnow receives the destination pipeline and the disease/count breakdown.FHIRBundleRecord: contains the serialized fhir bundle plus the diseases/count breakdown as metadata.CovidSummisionSummary: contains the RS response and other information relevant to covid reporting (e.g.: submissionId, org, destination).UniversalSummisionSummary: contains the RS response and other information relevant to universal reporting (e.g.: submissionId, org, destination).Pipeline: new type to represent COVID | UNIVERSAL pipeline names.TestResultUploadnow uses the @builder annotation.Testing
Code is available in dev2.