Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data-cy attribute for add patient spec #6859

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Oct 29, 2023

PULL REQUEST

Related Issue

Changes Proposed

  • use data-cy attributes to target elements for cypress spec 2

Additional Information

Testing

  • e2e test should pass
  • no functionality should be affected

@emyl3 emyl3 force-pushed the elisa/6465-spec2-part2 branch from 3f34fda to d890da5 Compare October 30, 2023 18:30
@emyl3 emyl3 force-pushed the elisa/6465-spec2-part2 branch from d890da5 to 03f59d9 Compare October 30, 2023 18:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

"extends": ["plugin:cypress/recommended"]
"extends": ["plugin:cypress/recommended"],
"rules": {
"cypress/require-data-selectors": "warn"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ can change this to "error" after we fix the rest of the specs

@emyl3 emyl3 marked this pull request as ready for review October 30, 2023 19:16
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks for working on this

@emyl3 emyl3 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit c6229f7 Oct 31, 2023
33 checks passed
@emyl3 emyl3 deleted the elisa/6465-spec2-part2 branch October 31, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make our e2e tests rerunnable and deterministic regardless of order (spec 2)
3 participants