Config Enhancements #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very useful to be able to build config in compontents. Config that is universal regardless of environment, and config that is enviornment specific. This allows mixing of config with a defined resolution order
It's entirely plausible that there might be situations where there is *only* a name and enviornment provided to cally, with no further config. The loader shouldn't throw an exception if this occurs
To make things a little easier downstream of the loader, having some basic validation will make errors more obvious
We are now using these args, no longer need to exclude them
This will drastically simplify producing a config compatible with the consuming command or action
This leans on the previous commits work to instantiate a stack via a dataclass
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Fixes
Refactor