Allow multivalue multiline header extraction for ApacheHttpClient #7996

sarahchen6 · 2024-11-21T22:41:30Z

What Does This Do

WIP split from #7943

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-11-21T23:18:28Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sarahchen6/allow-mulitline-headers-apachehttpclient
git_commit_date	1734455003	1734479023
git_commit_sha	`53cf809`	`d7277c9`
release_version	1.45.0-SNAPSHOT~53cf8096d1	1.45.0-SNAPSHOT~d7277c977d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734481387	1734481387
ci_job_id	743129067	743129067
ci_pipeline_id	51396319	51396319
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093544
Total [baseline] (10.437 s) : 0, 10436817
Agent [candidate] (1.095 s) : 0, 1095390
Total [candidate] (10.428 s) : 0, 10427724
section appsec
Agent [baseline] (1.234 s) : 0, 1234314
Total [baseline] (10.826 s) : 0, 10825966
Agent [candidate] (1.235 s) : 0, 1234505
Total [candidate] (10.686 s) : 0, 10685736
section iast
Agent [baseline] (1.229 s) : 0, 1228839
Total [baseline] (11.02 s) : 0, 11020312
Agent [candidate] (1.224 s) : 0, 1223797
Total [candidate] (11.04 s) : 0, 11039941
section profiling
Agent [baseline] (1.317 s) : 0, 1317449
Total [baseline] (10.831 s) : 0, 10831375
Agent [candidate] (1.32 s) : 0, 1319823
Total [candidate] (10.818 s) : 0, 10817613

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	appsec	1.234 s	140.77 ms (12.9%)
Agent	iast	1.229 s	135.295 ms (12.4%)
Agent	profiling	1.317 s	223.905 ms (20.5%)
Total	tracing	10.437 s	-
Total	appsec	10.826 s	389.149 ms (3.7%)
Total	iast	11.02 s	583.495 ms (5.6%)
Total	profiling	10.831 s	394.558 ms (3.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	appsec	1.235 s	139.115 ms (12.7%)
Agent	iast	1.224 s	128.406 ms (11.7%)
Agent	profiling	1.32 s	224.433 ms (20.5%)
Total	tracing	10.428 s	-
Total	appsec	10.686 s	258.012 ms (2.5%)
Total	iast	11.04 s	612.217 ms (5.9%)
Total	profiling	10.818 s	389.889 ms (3.7%)

gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.567 ms) : 0, 696567
BytebuddyAgent [candidate] (697.948 ms) : 0, 697948
GlobalTracer [baseline] (317.109 ms) : 0, 317109
GlobalTracer [candidate] (317.505 ms) : 0, 317505
AppSec [baseline] (54.723 ms) : 0, 54723
AppSec [candidate] (54.753 ms) : 0, 54753
Remote Config [baseline] (673.772 µs) : 0, 674
Remote Config [candidate] (680.63 µs) : 0, 681
Telemetry [baseline] (10.724 ms) : 0, 10724
Telemetry [candidate] (10.696 ms) : 0, 10696
section appsec
BytebuddyAgent [baseline] (717.411 ms) : 0, 717411
BytebuddyAgent [candidate] (718.199 ms) : 0, 718199
GlobalTracer [baseline] (316.721 ms) : 0, 316721
GlobalTracer [candidate] (316.385 ms) : 0, 316385
AppSec [baseline] (167.642 ms) : 0, 167642
AppSec [candidate] (167.543 ms) : 0, 167543
Remote Config [baseline] (659.16 µs) : 0, 659
Remote Config [candidate] (992.538 µs) : 0, 993
Telemetry [baseline] (8.594 ms) : 0, 8594
Telemetry [candidate] (8.081 ms) : 0, 8081
IAST [baseline] (19.057 ms) : 0, 19057
IAST [candidate] (18.931 ms) : 0, 18931
section iast
BytebuddyAgent [baseline] (819.827 ms) : 0, 819827
BytebuddyAgent [candidate] (815.105 ms) : 0, 815105
GlobalTracer [baseline] (307.545 ms) : 0, 307545
GlobalTracer [candidate] (307.447 ms) : 0, 307447
AppSec [baseline] (57.322 ms) : 0, 57322
AppSec [candidate] (57.382 ms) : 0, 57382
Remote Config [baseline] (617.214 µs) : 0, 617
Remote Config [candidate] (623.499 µs) : 0, 623
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (7.503 ms) : 0, 7503
IAST [baseline] (22.021 ms) : 0, 22021
IAST [candidate] (21.991 ms) : 0, 21991
section profiling
ProfilingAgent [baseline] (93.749 ms) : 0, 93749
ProfilingAgent [candidate] (92.918 ms) : 0, 92918
BytebuddyAgent [baseline] (690.223 ms) : 0, 690223
BytebuddyAgent [candidate] (690.796 ms) : 0, 690796
GlobalTracer [baseline] (432.164 ms) : 0, 432164
GlobalTracer [candidate] (434.85 ms) : 0, 434850
AppSec [baseline] (53.727 ms) : 0, 53727
AppSec [candidate] (53.618 ms) : 0, 53618
Remote Config [baseline] (671.534 µs) : 0, 672
Remote Config [candidate] (672.092 µs) : 0, 672
Telemetry [baseline] (7.675 ms) : 0, 7675
Telemetry [candidate] (7.729 ms) : 0, 7729
Profiling [baseline] (93.773 ms) : 0, 93773
Profiling [candidate] (92.941 ms) : 0, 92941

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1094649
Total [baseline] (8.688 s) : 0, 8688458
Agent [candidate] (1.094 s) : 0, 1094202
Total [candidate] (8.638 s) : 0, 8638043
section iast
Agent [baseline] (1.221 s) : 0, 1221157
Total [baseline] (9.237 s) : 0, 9237391
Agent [candidate] (1.223 s) : 0, 1223010
Total [candidate] (9.245 s) : 0, 9244676
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.229 s) : 0, 1228939
Total [baseline] (9.193 s) : 0, 9192878
Agent [candidate] (1.231 s) : 0, 1231327
Total [candidate] (9.193 s) : 0, 9193424
section iast_TELEMETRY_OFF
Agent [baseline] (1.23 s) : 0, 1229725
Total [baseline] (9.224 s) : 0, 9223719
Agent [candidate] (1.222 s) : 0, 1222321
Total [candidate] (9.19 s) : 0, 9189958

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	iast	1.221 s	126.508 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.229 s	134.29 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.23 s	135.076 ms (12.3%)
Total	tracing	8.688 s	-
Total	iast	9.237 s	548.932 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.193 s	504.42 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.224 s	535.261 ms (6.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	iast	1.223 s	128.808 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.231 s	137.125 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.222 s	128.118 ms (11.7%)
Total	tracing	8.638 s	-
Total	iast	9.245 s	606.633 ms (7.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.193 s	555.381 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.19 s	551.915 ms (6.4%)

gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.629 ms) : 0, 696629
BytebuddyAgent [candidate] (694.503 ms) : 0, 694503
GlobalTracer [baseline] (317.501 ms) : 0, 317501
GlobalTracer [candidate] (317.412 ms) : 0, 317412
AppSec [baseline] (54.697 ms) : 0, 54697
AppSec [candidate] (54.252 ms) : 0, 54252
Remote Config [baseline] (684.546 µs) : 0, 685
Remote Config [candidate] (687.56 µs) : 0, 688
Telemetry [baseline] (11.258 ms) : 0, 11258
Telemetry [candidate] (13.62 ms) : 0, 13620
section iast
BytebuddyAgent [baseline] (813.932 ms) : 0, 813932
BytebuddyAgent [candidate] (814.979 ms) : 0, 814979
GlobalTracer [baseline] (306.199 ms) : 0, 306199
GlobalTracer [candidate] (306.674 ms) : 0, 306674
AppSec [baseline] (57.228 ms) : 0, 57228
AppSec [candidate] (58.171 ms) : 0, 58171
Remote Config [baseline] (615.603 µs) : 0, 616
Remote Config [candidate] (613.409 µs) : 0, 613
Telemetry [baseline] (7.501 ms) : 0, 7501
Telemetry [candidate] (7.571 ms) : 0, 7571
IAST [baseline] (21.917 ms) : 0, 21917
IAST [candidate] (21.247 ms) : 0, 21247
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (820.025 ms) : 0, 820025
BytebuddyAgent [candidate] (821.193 ms) : 0, 821193
GlobalTracer [baseline] (307.544 ms) : 0, 307544
GlobalTracer [candidate] (308.668 ms) : 0, 308668
AppSec [baseline] (56.914 ms) : 0, 56914
AppSec [candidate] (57.53 ms) : 0, 57530
Remote Config [baseline] (608.821 µs) : 0, 609
Remote Config [candidate] (619.693 µs) : 0, 620
Telemetry [baseline] (7.437 ms) : 0, 7437
Telemetry [candidate] (7.5 ms) : 0, 7500
IAST [baseline] (22.539 ms) : 0, 22539
IAST [candidate] (21.949 ms) : 0, 21949
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (818.606 ms) : 0, 818606
BytebuddyAgent [candidate] (813.021 ms) : 0, 813021
GlobalTracer [baseline] (309.39 ms) : 0, 309390
GlobalTracer [candidate] (307.807 ms) : 0, 307807
AppSec [baseline] (57.72 ms) : 0, 57720
AppSec [candidate] (58.738 ms) : 0, 58738
Remote Config [baseline] (633.146 µs) : 0, 633
Remote Config [candidate] (642.651 µs) : 0, 643
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (7.45 ms) : 0, 7450
IAST [baseline] (21.835 ms) : 0, 21835
IAST [candidate] (20.851 ms) : 0, 20851

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-17T23:55:10	2024-12-18T00:02:08
git_branch	master	sarahchen6/allow-mulitline-headers-apachehttpclient
git_commit_date	1734455003	1734479023
git_commit_sha	`53cf809`	`d7277c9`
release_version	1.45.0-SNAPSHOT~53cf8096d1	1.45.0-SNAPSHOT~d7277c977d
start_time	2024-12-17T23:54:57	2024-12-18T00:01:55

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734480480	1734480480
ci_job_id	743129068	743129068
ci_pipeline_id	51396319	51396319
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1322, 1362
.   : milestone, 1342,
appsec (1.752 ms) : 1728, 1775
.   : milestone, 1752,
appsec_no_iast (1.734 ms) : 1709, 1760
.   : milestone, 1734,
iast (1.499 ms) : 1477, 1522
.   : milestone, 1499,
profiling (1.542 ms) : 1518, 1567
.   : milestone, 1542,
tracing (1.508 ms) : 1484, 1532
.   : milestone, 1508,
section candidate
no_agent (1.339 ms) : 1319, 1358
.   : milestone, 1339,
appsec (1.74 ms) : 1717, 1764
.   : milestone, 1740,
appsec_no_iast (1.778 ms) : 1754, 1803
.   : milestone, 1778,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.514 ms) : 1491, 1538
.   : milestone, 1514,
tracing (1.491 ms) : 1467, 1515
.   : milestone, 1491,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.342 ms [1.322 ms, 1.362 ms]	-
appsec	1.752 ms [1.728 ms, 1.775 ms]	409.271 µs (30.5%)
appsec_no_iast	1.734 ms [1.709 ms, 1.76 ms]	392.025 µs (29.2%)
iast	1.499 ms [1.477 ms, 1.522 ms]	157.115 µs (11.7%)
profiling	1.542 ms [1.518 ms, 1.567 ms]	199.939 µs (14.9%)
tracing	1.508 ms [1.484 ms, 1.532 ms]	165.666 µs (12.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.339 ms [1.319 ms, 1.358 ms]	-
appsec	1.74 ms [1.717 ms, 1.764 ms]	401.468 µs (30.0%)
appsec_no_iast	1.778 ms [1.754 ms, 1.803 ms]	439.573 µs (32.8%)
iast	1.491 ms [1.468 ms, 1.514 ms]	152.126 µs (11.4%)
profiling	1.514 ms [1.491 ms, 1.538 ms]	175.246 µs (13.1%)
tracing	1.491 ms [1.467 ms, 1.515 ms]	152.085 µs (11.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.224 µs) : 357, 396
.   : milestone, 376,
iast (488.509 µs) : 467, 510
.   : milestone, 489,
iast_FULL (646.067 µs) : 625, 668
.   : milestone, 646,
iast_GLOBAL (517.513 µs) : 496, 539
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (491.272 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (444.736 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (472.971 µs) : 452, 494
.   : milestone, 473,
tracing (442.479 µs) : 422, 463
.   : milestone, 442,
section candidate
no_agent (371.985 µs) : 351, 393
.   : milestone, 372,
iast (491.61 µs) : 470, 514
.   : milestone, 492,
iast_FULL (644.517 µs) : 623, 666
.   : milestone, 645,
iast_GLOBAL (518.281 µs) : 496, 540
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (488.263 µs) : 467, 510
.   : milestone, 488,
iast_INACTIVE (458.225 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (482.438 µs) : 460, 505
.   : milestone, 482,
tracing (442.122 µs) : 421, 463
.   : milestone, 442,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.224 µs [356.841 µs, 395.608 µs]	-
iast	488.509 µs [466.986 µs, 510.032 µs]	112.285 µs (29.8%)
iast_FULL	646.067 µs [624.567 µs, 667.567 µs]	269.843 µs (71.7%)
iast_GLOBAL	517.513 µs [495.736 µs, 539.289 µs]	141.289 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED	491.272 µs [469.702 µs, 512.842 µs]	115.048 µs (30.6%)
iast_INACTIVE	444.736 µs [424.013 µs, 465.459 µs]	68.512 µs (18.2%)
iast_TELEMETRY_OFF	472.971 µs [451.833 µs, 494.109 µs]	96.747 µs (25.7%)
tracing	442.479 µs [421.928 µs, 463.03 µs]	66.255 µs (17.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.985 µs [351.282 µs, 392.688 µs]	-
iast	491.61 µs [469.526 µs, 513.693 µs]	119.624 µs (32.2%)
iast_FULL	644.517 µs [622.929 µs, 666.106 µs]	272.532 µs (73.3%)
iast_GLOBAL	518.281 µs [496.099 µs, 540.464 µs]	146.296 µs (39.3%)
iast_HARDCODED_SECRET_DISABLED	488.263 µs [466.96 µs, 509.566 µs]	116.278 µs (31.3%)
iast_INACTIVE	458.225 µs [436.592 µs, 479.858 µs]	86.24 µs (23.2%)
iast_TELEMETRY_OFF	482.438 µs [459.69 µs, 505.185 µs]	110.452 µs (29.7%)
tracing	442.122 µs [421.359 µs, 462.884 µs]	70.136 µs (18.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sarahchen6/allow-mulitline-headers-apachehttpclient
git_commit_date	1734455003	1734479023
git_commit_sha	`53cf809`	`d7277c9`
release_version	1.45.0-SNAPSHOT~53cf8096d1	1.45.0-SNAPSHOT~d7277c977d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1734481229	1734481229
ci_job_id	743129069	743129069
ci_pipeline_id	51396319	51396319
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 7 metrics, 0 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:dacapo:tomcat:appsec	worse [+3.001ms; +3.109ms] or [+127.329%; +131.912%]	5.412ms	2.357ms
scenario:dacapo:tomcat:iast	worse [+3.247ms; +3.375ms] or [+154.120%; +160.200%]	5.418ms	2.107ms
scenario:dacapo:tomcat:iast_GLOBAL	worse [+3.227ms; +3.356ms] or [+150.446%; +156.432%]	5.437ms	2.145ms
scenario:dacapo:tomcat:profiling	worse [+3.512ms; +3.625ms] or [+176.870%; +182.607%]	5.554ms	1.985ms
scenario:dacapo:tomcat:tracing	worse [+3.437ms; +3.544ms] or [+176.977%; +182.479%]	5.432ms	1.942ms

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.357 ms) : 2315, 2399
.   : milestone, 2357,
iast (2.107 ms) : 2053, 2160
.   : milestone, 2107,
iast_GLOBAL (2.145 ms) : 2092, 2199
.   : milestone, 2145,
profiling (1.985 ms) : 1942, 2029
.   : milestone, 1985,
tracing (1.942 ms) : 1901, 1983
.   : milestone, 1942,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (5.412 ms) : 5354, 5469
.   : milestone, 5412,
iast (5.418 ms) : 5353, 5483
.   : milestone, 5418,
iast_GLOBAL (5.437 ms) : 5372, 5502
.   : milestone, 5437,
profiling (5.554 ms) : 5493, 5615
.   : milestone, 5554,
tracing (5.432 ms) : 5375, 5489
.   : milestone, 5432,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.357 ms [2.315 ms, 2.399 ms]	885.929 µs (60.2%)
iast	2.107 ms [2.053 ms, 2.16 ms]	636.004 µs (43.2%)
iast_GLOBAL	2.145 ms [2.092 ms, 2.199 ms]	674.386 µs (45.9%)
profiling	1.985 ms [1.942 ms, 2.029 ms]	514.554 µs (35.0%)
tracing	1.942 ms [1.901 ms, 1.983 ms]	471.182 µs (32.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	5.412 ms [5.354 ms, 5.469 ms]	3.939 ms (267.5%)
iast	5.418 ms [5.353 ms, 5.483 ms]	3.945 ms (267.9%)
iast_GLOBAL	5.437 ms [5.372 ms, 5.502 ms]	3.964 ms (269.2%)
profiling	5.554 ms [5.493 ms, 5.615 ms]	4.081 ms (277.2%)
tracing	5.432 ms [5.375 ms, 5.489 ms]	3.96 ms (268.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~d7277c977d, baseline=1.45.0-SNAPSHOT~53cf8096d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.306 s) : 15306000, 15306000
.   : milestone, 15306000,
appsec (15.025 s) : 15025000, 15025000
.   : milestone, 15025000,
iast (18.874 s) : 18874000, 18874000
.   : milestone, 18874000,
iast_GLOBAL (18.116 s) : 18116000, 18116000
.   : milestone, 18116000,
profiling (14.932 s) : 14932000, 14932000
.   : milestone, 14932000,
tracing (15.153 s) : 15153000, 15153000
.   : milestone, 15153000,
section candidate
no_agent (15.038 s) : 15038000, 15038000
.   : milestone, 15038000,
appsec (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
iast (18.506 s) : 18506000, 18506000
.   : milestone, 18506000,
iast_GLOBAL (17.618 s) : 17618000, 17618000
.   : milestone, 17618000,
profiling (14.909 s) : 14909000, 14909000
.   : milestone, 14909000,
tracing (15.098 s) : 15098000, 15098000
.   : milestone, 15098000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.306 s [15.306 s, 15.306 s]	-
appsec	15.025 s [15.025 s, 15.025 s]	-281.0 ms (-1.8%)
iast	18.874 s [18.874 s, 18.874 s]	3.568 s (23.3%)
iast_GLOBAL	18.116 s [18.116 s, 18.116 s]	2.81 s (18.4%)
profiling	14.932 s [14.932 s, 14.932 s]	-374.0 ms (-2.4%)
tracing	15.153 s [15.153 s, 15.153 s]	-153.0 ms (-1.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.038 s [15.038 s, 15.038 s]	-
appsec	15.187 s [15.187 s, 15.187 s]	149.0 ms (1.0%)
iast	18.506 s [18.506 s, 18.506 s]	3.468 s (23.1%)
iast_GLOBAL	17.618 s [17.618 s, 17.618 s]	2.58 s (17.2%)
profiling	14.909 s [14.909 s, 14.909 s]	-129.0 ms (-0.9%)
tracing	15.098 s [15.098 s, 15.098 s]	60.0 ms (0.4%)

github-actions · 2024-12-17T23:44:38Z

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

Update the submodule to the latest commit on the master branch using the git submodule update command,
Check you properly set up your environment for contributing.

sarahchen6 · 2025-01-22T20:43:11Z

outdated

sarahchen6 force-pushed the sarahchen6/allow-mulitline-headers-apachehttpclient branch from 6b10416 to d7f1afa Compare November 22, 2024 20:55

sarahchen6 changed the title ~~Allow multvalue multiline header extraction for ApacheHttpClient~~ Allow multivalue multiline header extraction for ApacheHttpClient Nov 22, 2024

sarahchen6 force-pushed the sarahchen6/allow-mulitline-headers-apachehttpclient branch 3 times, most recently from 4e31acf to a3ef21a Compare December 6, 2024 20:06

sarahchen6 force-pushed the sarahchen6/allow-mulitline-headers-apachehttpclient branch 7 times, most recently from c800f46 to 6362dbd Compare December 14, 2024 03:38

sarahchen6 mentioned this pull request Dec 14, 2024

[WIP] Handle multi-value tagging for client spans #7943

Closed

5 tasks

sarahchen6 force-pushed the sarahchen6/allow-mulitline-headers-apachehttpclient branch 4 times, most recently from dc19107 to d0b9b5a Compare December 15, 2024 23:04

sarahchen6 added 12 commits December 17, 2024 16:48

Add tests

a35ef50

Fix apachehttpclients so that they accept multiple headers

989ec95

Debug print statements

811cb7a

Adjust decorators

35f81a7

Adjust doRequest

efb65ac

Fix apachehttpasyncclient so that it accepts multiple headers

c748c1e

Add print statement

456e2f9

lots of debug

dd5c183

debug more

a4f4c6a

Change getHeader to getHeaders in HttpServletRequestExtractAdapter

8168166

More debugging

8d1f18a

even more debugging

0c29cd2

sarahchen6 added 8 commits December 17, 2024 16:48

Add getHeaders to HostAndRequestAsHttpUriRequest

9bc6720

Adjust decorators

6c88548

Add getHeaders to all HostAndRequestAsHttpUriRequest

9bfcd68

Update doRequest

04a3d84

Uncomment tests and adjust doRequests

a4757ab

Remove extra line..

43718e9

Fix Grizzly ClientDecorator

af906f0

Fix JettyClientDecorator

520e952

sarahchen6 force-pushed the sarahchen6/allow-mulitline-headers-apachehttpclient branch from d0b9b5a to 520e952 Compare December 17, 2024 22:48

Separate tests

d7277c9

sarahchen6 mentioned this pull request Dec 18, 2024

Allow multivalue multiline header extraction #8112

Draft

sarahchen6 closed this Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow multivalue multiline header extraction for ApacheHttpClient #7996

Allow multivalue multiline header extraction for ApacheHttpClient #7996

sarahchen6 commented Nov 21, 2024

pr-commenter bot commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024

sarahchen6 commented Jan 22, 2025

Allow multivalue multiline header extraction for ApacheHttpClient #7996

Allow multivalue multiline header extraction for ApacheHttpClient #7996

Conversation

sarahchen6 commented Nov 21, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Nov 21, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions bot commented Dec 17, 2024

sarahchen6 commented Jan 22, 2025

pr-commenter bot commented Nov 21, 2024 •

edited

Loading