-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagating baggage, redux #8233
Draft
lucaspimentel
wants to merge
2
commits into
master
Choose a base branch
from
lpimentel/opentelemetry-baggage-decorator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+67
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052562
Total [baseline] (8.618 s) : 0, 8617557
Agent [candidate] (1.065 s) : 0, 1064774
Total [candidate] (8.642 s) : 0, 8641666
section iast
Agent [baseline] (1.181 s) : 0, 1180980
Total [baseline] (9.168 s) : 0, 9168268
Agent [candidate] (1.183 s) : 0, 1183023
Total [candidate] (9.261 s) : 0, 9260773
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1189855
Total [baseline] (9.25 s) : 0, 9249683
Agent [candidate] (1.183 s) : 0, 1182967
Total [candidate] (9.182 s) : 0, 9182164
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1178466
Total [baseline] (9.196 s) : 0, 9195891
Agent [candidate] (1.185 s) : 0, 1185493
Total [candidate] (9.269 s) : 0, 9268741
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.884 ms) : 0, 712884
BytebuddyAgent [candidate] (720.218 ms) : 0, 720218
GlobalTracer [baseline] (255.06 ms) : 0, 255060
GlobalTracer [candidate] (258.529 ms) : 0, 258529
AppSec [baseline] (56.66 ms) : 0, 56660
AppSec [candidate] (56.447 ms) : 0, 56447
Remote Config [baseline] (713.598 µs) : 0, 714
Remote Config [candidate] (732.724 µs) : 0, 733
Telemetry [baseline] (12.304 ms) : 0, 12304
Telemetry [candidate] (13.771 ms) : 0, 13771
section iast
BytebuddyAgent [baseline] (830.913 ms) : 0, 830913
BytebuddyAgent [candidate] (832.463 ms) : 0, 832463
GlobalTracer [baseline] (246.242 ms) : 0, 246242
GlobalTracer [candidate] (247.101 ms) : 0, 247101
AppSec [baseline] (58.125 ms) : 0, 58125
AppSec [candidate] (58.001 ms) : 0, 58001
IAST [baseline] (21.365 ms) : 0, 21365
IAST [candidate] (21.071 ms) : 0, 21071
Remote Config [baseline] (644.977 µs) : 0, 645
Remote Config [candidate] (659.576 µs) : 0, 660
Telemetry [baseline] (8.728 ms) : 0, 8728
Telemetry [candidate] (8.744 ms) : 0, 8744
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.806 ms) : 0, 838806
BytebuddyAgent [candidate] (831.854 ms) : 0, 831854
GlobalTracer [baseline] (247.037 ms) : 0, 247037
GlobalTracer [candidate] (247.295 ms) : 0, 247295
AppSec [baseline] (57.899 ms) : 0, 57899
AppSec [candidate] (57.867 ms) : 0, 57867
IAST [baseline] (21.54 ms) : 0, 21540
IAST [candidate] (21.507 ms) : 0, 21507
Remote Config [baseline] (669.569 µs) : 0, 670
Remote Config [candidate] (679.62 µs) : 0, 680
Telemetry [baseline] (8.77 ms) : 0, 8770
Telemetry [candidate] (8.756 ms) : 0, 8756
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.737 ms) : 0, 828737
BytebuddyAgent [candidate] (832.411 ms) : 0, 832411
GlobalTracer [baseline] (246.424 ms) : 0, 246424
GlobalTracer [candidate] (249.066 ms) : 0, 249066
AppSec [baseline] (58.015 ms) : 0, 58015
AppSec [candidate] (58.37 ms) : 0, 58370
IAST [baseline] (21.003 ms) : 0, 21003
IAST [candidate] (21.216 ms) : 0, 21216
Remote Config [baseline] (683.583 µs) : 0, 684
Remote Config [candidate] (669.199 µs) : 0, 669
Telemetry [baseline] (8.658 ms) : 0, 8658
Telemetry [candidate] (8.726 ms) : 0, 8726
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056351
Total [baseline] (10.42 s) : 0, 10420408
Agent [candidate] (1.064 s) : 0, 1064092
Total [candidate] (10.508 s) : 0, 10508375
section appsec
Agent [baseline] (1.195 s) : 0, 1195353
Total [baseline] (10.774 s) : 0, 10774398
Agent [candidate] (1.189 s) : 0, 1188573
Total [candidate] (10.75 s) : 0, 10750447
section iast
Agent [baseline] (1.186 s) : 0, 1185643
Total [baseline] (10.971 s) : 0, 10971033
Agent [candidate] (1.189 s) : 0, 1188518
Total [candidate] (10.97 s) : 0, 10969716
section profiling
Agent [baseline] (1.253 s) : 0, 1252529
Total [baseline] (10.809 s) : 0, 10809366
Agent [candidate] (1.255 s) : 0, 1255200
Total [candidate] (10.874 s) : 0, 10873955
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.558 ms) : 0, 714558
BytebuddyAgent [candidate] (720.162 ms) : 0, 720162
GlobalTracer [baseline] (255.958 ms) : 0, 255958
GlobalTracer [candidate] (257.611 ms) : 0, 257611
AppSec [baseline] (57.35 ms) : 0, 57350
AppSec [candidate] (55.591 ms) : 0, 55591
Remote Config [baseline] (711.333 µs) : 0, 711
Remote Config [candidate] (729.374 µs) : 0, 729
Telemetry [baseline] (12.803 ms) : 0, 12803
Telemetry [candidate] (15.004 ms) : 0, 15004
section appsec
BytebuddyAgent [baseline] (735.278 ms) : 0, 735278
BytebuddyAgent [candidate] (730.142 ms) : 0, 730142
GlobalTracer [baseline] (254.62 ms) : 0, 254620
GlobalTracer [candidate] (253.389 ms) : 0, 253389
AppSec [baseline] (171.792 ms) : 0, 171792
AppSec [candidate] (171.315 ms) : 0, 171315
Remote Config [baseline] (664.941 µs) : 0, 665
Remote Config [candidate] (681.613 µs) : 0, 682
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.246 ms) : 0, 8246
IAST [baseline] (19.619 ms) : 0, 19619
IAST [candidate] (19.62 ms) : 0, 19620
section iast
BytebuddyAgent [baseline] (833.839 ms) : 0, 833839
BytebuddyAgent [candidate] (837.157 ms) : 0, 837157
GlobalTracer [baseline] (247.469 ms) : 0, 247469
GlobalTracer [candidate] (247.16 ms) : 0, 247160
AppSec [baseline] (58.071 ms) : 0, 58071
AppSec [candidate] (58.204 ms) : 0, 58204
Remote Config [baseline] (666.122 µs) : 0, 666
Remote Config [candidate] (676.251 µs) : 0, 676
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (8.785 ms) : 0, 8785
IAST [baseline] (21.742 ms) : 0, 21742
IAST [candidate] (21.469 ms) : 0, 21469
section profiling
ProfilingAgent [baseline] (95.35 ms) : 0, 95350
ProfilingAgent [candidate] (95.26 ms) : 0, 95260
BytebuddyAgent [baseline] (702.505 ms) : 0, 702505
BytebuddyAgent [candidate] (703.411 ms) : 0, 703411
GlobalTracer [baseline] (348.863 ms) : 0, 348863
GlobalTracer [candidate] (350.501 ms) : 0, 350501
AppSec [baseline] (54.483 ms) : 0, 54483
AppSec [candidate] (54.61 ms) : 0, 54610
Remote Config [baseline] (666.669 µs) : 0, 667
Remote Config [candidate] (661.259 µs) : 0, 661
Telemetry [baseline] (8.852 ms) : 0, 8852
Telemetry [candidate] (8.846 ms) : 0, 8846
Profiling [baseline] (95.374 ms) : 0, 95374
Profiling [candidate] (95.285 ms) : 0, 95285
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (1.359 ms) : 1339, 1379
. : milestone, 1359,
appsec (1.729 ms) : 1706, 1752
. : milestone, 1729,
appsec_no_iast (1.779 ms) : 1755, 1804
. : milestone, 1779,
iast (1.48 ms) : 1455, 1505
. : milestone, 1480,
profiling (1.498 ms) : 1475, 1522
. : milestone, 1498,
tracing (1.493 ms) : 1469, 1518
. : milestone, 1493,
section candidate
no_agent (1.341 ms) : 1322, 1361
. : milestone, 1341,
appsec (1.743 ms) : 1719, 1767
. : milestone, 1743,
appsec_no_iast (1.773 ms) : 1750, 1795
. : milestone, 1773,
iast (1.494 ms) : 1471, 1518
. : milestone, 1494,
profiling (1.501 ms) : 1477, 1524
. : milestone, 1501,
tracing (1.498 ms) : 1473, 1522
. : milestone, 1498,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (379.795 µs) : 359, 401
. : milestone, 380,
iast (504.67 µs) : 483, 526
. : milestone, 505,
iast_FULL (740.99 µs) : 719, 763
. : milestone, 741,
iast_GLOBAL (553.973 µs) : 532, 576
. : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (501.094 µs) : 479, 523
. : milestone, 501,
iast_INACTIVE (454.155 µs) : 433, 476
. : milestone, 454,
iast_TELEMETRY_OFF (496.739 µs) : 475, 519
. : milestone, 497,
tracing (464.833 µs) : 444, 486
. : milestone, 465,
section candidate
no_agent (373.706 µs) : 354, 393
. : milestone, 374,
iast (493.229 µs) : 471, 515
. : milestone, 493,
iast_FULL (653.056 µs) : 631, 675
. : milestone, 653,
iast_GLOBAL (522.391 µs) : 500, 545
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (490.855 µs) : 469, 513
. : milestone, 491,
iast_INACTIVE (450.224 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (482.703 µs) : 461, 504
. : milestone, 483,
tracing (442.86 µs) : 422, 464
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.382 ms) : 2339, 2425
. : milestone, 2382,
iast (2.122 ms) : 2067, 2176
. : milestone, 2122,
iast_GLOBAL (2.163 ms) : 2109, 2218
. : milestone, 2163,
profiling (1.99 ms) : 1947, 2034
. : milestone, 1990,
tracing (1.962 ms) : 1921, 2004
. : milestone, 1962,
section candidate
no_agent (1.475 ms) : 1464, 1486
. : milestone, 1475,
appsec (2.382 ms) : 2339, 2425
. : milestone, 2382,
iast (2.12 ms) : 2066, 2174
. : milestone, 2120,
iast_GLOBAL (2.172 ms) : 2117, 2227
. : milestone, 2172,
profiling (1.987 ms) : 1943, 2031
. : milestone, 1987,
tracing (1.955 ms) : 1914, 1997
. : milestone, 1955,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~029c5040a6, baseline=1.46.0-SNAPSHOT~f1d359b93f
dateFormat X
axisFormat %s
section baseline
no_agent (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
appsec (14.772 s) : 14772000, 14772000
. : milestone, 14772000,
iast (18.76 s) : 18760000, 18760000
. : milestone, 18760000,
iast_GLOBAL (18.424 s) : 18424000, 18424000
. : milestone, 18424000,
profiling (15.695 s) : 15695000, 15695000
. : milestone, 15695000,
tracing (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
section candidate
no_agent (14.651 s) : 14651000, 14651000
. : milestone, 14651000,
appsec (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
iast (19.196 s) : 19196000, 19196000
. : milestone, 19196000,
iast_GLOBAL (17.743 s) : 17743000, 17743000
. : milestone, 17743000,
profiling (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
tracing (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
|
lucaspimentel
changed the title
propagating W3C
propagating baggage, redux
Jan 17, 2025
baggage
header, redux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for propagating baggage using the W3C
baggage
header (as used by OpenTelemetry).https://www.w3.org/TR/baggage/
Motivation
This is a user-requested feature that we are adding to all tracing libraries for OpenTelemetry compatibility.
Additional Notes
My first attempt was #8203 (early draft).
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMAPI-214