-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set test framework and test framework version tags atomically #8252
Open
nikita-tkachenko-datadog
wants to merge
1
commit into
master
Choose a base branch
from
nikita-tkachenko/test-framework-tags-sync
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Set test framework and test framework version tags atomically #8252
nikita-tkachenko-datadog
wants to merge
1
commit into
master
from
nikita-tkachenko/test-framework-tags-sync
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Jan 20, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055978
Total [baseline] (8.615 s) : 0, 8614617
Agent [candidate] (1.062 s) : 0, 1061777
Total [candidate] (8.632 s) : 0, 8631652
section iast
Agent [baseline] (1.184 s) : 0, 1184465
Total [baseline] (9.162 s) : 0, 9162487
Agent [candidate] (1.185 s) : 0, 1184983
Total [candidate] (9.219 s) : 0, 9218862
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1182340
Total [baseline] (9.163 s) : 0, 9162918
Agent [candidate] (1.181 s) : 0, 1181259
Total [candidate] (9.142 s) : 0, 9142162
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1179112
Total [baseline] (9.171 s) : 0, 9171151
Agent [candidate] (1.18 s) : 0, 1179620
Total [candidate] (9.201 s) : 0, 9200735
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.965 ms) : 0, 715965
BytebuddyAgent [candidate] (718.326 ms) : 0, 718326
GlobalTracer [baseline] (255.821 ms) : 0, 255821
GlobalTracer [candidate] (257.224 ms) : 0, 257224
AppSec [baseline] (56.329 ms) : 0, 56329
AppSec [candidate] (56.019 ms) : 0, 56019
Remote Config [baseline] (735.696 µs) : 0, 736
Remote Config [candidate] (746.89 µs) : 0, 747
Telemetry [baseline] (12.129 ms) : 0, 12129
Telemetry [candidate] (14.408 ms) : 0, 14408
section iast
BytebuddyAgent [baseline] (833.283 ms) : 0, 833283
BytebuddyAgent [candidate] (832.971 ms) : 0, 832971
GlobalTracer [baseline] (246.809 ms) : 0, 246809
GlobalTracer [candidate] (247.046 ms) : 0, 247046
AppSec [baseline] (58.129 ms) : 0, 58129
AppSec [candidate] (58.583 ms) : 0, 58583
IAST [baseline] (21.786 ms) : 0, 21786
IAST [candidate] (21.802 ms) : 0, 21802
Remote Config [baseline] (679.525 µs) : 0, 680
Remote Config [candidate] (703.174 µs) : 0, 703
Telemetry [baseline] (8.759 ms) : 0, 8759
Telemetry [candidate] (8.794 ms) : 0, 8794
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.23 ms) : 0, 832230
BytebuddyAgent [candidate] (830.734 ms) : 0, 830734
GlobalTracer [baseline] (246.048 ms) : 0, 246048
GlobalTracer [candidate] (246.47 ms) : 0, 246470
AppSec [baseline] (57.939 ms) : 0, 57939
AppSec [candidate] (58.118 ms) : 0, 58118
IAST [baseline] (21.645 ms) : 0, 21645
IAST [candidate] (21.494 ms) : 0, 21494
Remote Config [baseline] (662.495 µs) : 0, 662
Remote Config [candidate] (685.548 µs) : 0, 686
Telemetry [baseline] (8.768 ms) : 0, 8768
Telemetry [candidate] (8.803 ms) : 0, 8803
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.923 ms) : 0, 828923
BytebuddyAgent [candidate] (829.679 ms) : 0, 829679
GlobalTracer [baseline] (246.704 ms) : 0, 246704
GlobalTracer [candidate] (246.91 ms) : 0, 246910
AppSec [baseline] (58.101 ms) : 0, 58101
AppSec [candidate] (57.827 ms) : 0, 57827
IAST [baseline] (20.972 ms) : 0, 20972
IAST [candidate] (20.808 ms) : 0, 20808
Remote Config [baseline] (677.869 µs) : 0, 678
Remote Config [candidate] (652.369 µs) : 0, 652
Telemetry [baseline] (8.725 ms) : 0, 8725
Telemetry [candidate] (8.666 ms) : 0, 8666
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051753
Total [baseline] (10.398 s) : 0, 10397828
Agent [candidate] (1.055 s) : 0, 1054776
Total [candidate] (10.455 s) : 0, 10454727
section appsec
Agent [baseline] (1.189 s) : 0, 1189105
Total [baseline] (10.732 s) : 0, 10731692
Agent [candidate] (1.194 s) : 0, 1193877
Total [candidate] (10.733 s) : 0, 10732777
section iast
Agent [baseline] (1.196 s) : 0, 1195583
Total [baseline] (11.011 s) : 0, 11011234
Agent [candidate] (1.193 s) : 0, 1192809
Total [candidate] (11.003 s) : 0, 11003199
section profiling
Agent [baseline] (1.259 s) : 0, 1258907
Total [baseline] (10.759 s) : 0, 10758712
Agent [candidate] (1.256 s) : 0, 1255609
Total [candidate] (10.8 s) : 0, 10800345
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.698 ms) : 0, 712698
BytebuddyAgent [candidate] (714.503 ms) : 0, 714503
GlobalTracer [baseline] (254.568 ms) : 0, 254568
GlobalTracer [candidate] (255.807 ms) : 0, 255807
AppSec [baseline] (55.469 ms) : 0, 55469
AppSec [candidate] (56.374 ms) : 0, 56374
Remote Config [baseline] (737.882 µs) : 0, 738
Remote Config [candidate] (744.743 µs) : 0, 745
Telemetry [baseline] (13.308 ms) : 0, 13308
Telemetry [candidate] (12.321 ms) : 0, 12321
section appsec
BytebuddyAgent [baseline] (732.337 ms) : 0, 732337
BytebuddyAgent [candidate] (734.663 ms) : 0, 734663
GlobalTracer [baseline] (252.32 ms) : 0, 252320
GlobalTracer [candidate] (253.809 ms) : 0, 253809
AppSec [baseline] (171.051 ms) : 0, 171051
AppSec [candidate] (171.318 ms) : 0, 171318
IAST [baseline] (19.205 ms) : 0, 19205
IAST [candidate] (19.477 ms) : 0, 19477
Remote Config [baseline] (670.817 µs) : 0, 671
Remote Config [candidate] (681.737 µs) : 0, 682
Telemetry [baseline] (8.107 ms) : 0, 8107
Telemetry [candidate] (8.575 ms) : 0, 8575
section iast
BytebuddyAgent [baseline] (841.356 ms) : 0, 841356
BytebuddyAgent [candidate] (839.091 ms) : 0, 839091
GlobalTracer [baseline] (249.208 ms) : 0, 249208
GlobalTracer [candidate] (248.389 ms) : 0, 248389
AppSec [baseline] (58.485 ms) : 0, 58485
AppSec [candidate] (58.643 ms) : 0, 58643
IAST [baseline] (21.823 ms) : 0, 21823
IAST [candidate] (21.894 ms) : 0, 21894
Remote Config [baseline] (673.979 µs) : 0, 674
Remote Config [candidate] (675.129 µs) : 0, 675
Telemetry [baseline] (8.931 ms) : 0, 8931
Telemetry [candidate] (8.9 ms) : 0, 8900
section profiling
BytebuddyAgent [baseline] (706.311 ms) : 0, 706311
BytebuddyAgent [candidate] (704.207 ms) : 0, 704207
GlobalTracer [baseline] (349.51 ms) : 0, 349510
GlobalTracer [candidate] (350.443 ms) : 0, 350443
AppSec [baseline] (55.148 ms) : 0, 55148
AppSec [candidate] (54.203 ms) : 0, 54203
Remote Config [baseline] (729.138 µs) : 0, 729
Remote Config [candidate] (720.195 µs) : 0, 720
Telemetry [baseline] (8.809 ms) : 0, 8809
Telemetry [candidate] (8.77 ms) : 0, 8770
ProfilingAgent [baseline] (96.152 ms) : 0, 96152
ProfilingAgent [candidate] (95.311 ms) : 0, 95311
Profiling [baseline] (96.176 ms) : 0, 96176
Profiling [candidate] (95.334 ms) : 0, 95334
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section baseline
no_agent (377.117 µs) : 357, 397
. : milestone, 377,
iast (507.219 µs) : 486, 529
. : milestone, 507,
iast_FULL (735.696 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (551.106 µs) : 530, 573
. : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (505.971 µs) : 484, 528
. : milestone, 506,
iast_INACTIVE (455.812 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (494.541 µs) : 473, 516
. : milestone, 495,
tracing (457.006 µs) : 433, 481
. : milestone, 457,
section candidate
no_agent (378.312 µs) : 359, 398
. : milestone, 378,
iast (508.835 µs) : 487, 531
. : milestone, 509,
iast_FULL (742.228 µs) : 720, 764
. : milestone, 742,
iast_GLOBAL (560.358 µs) : 538, 583
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (503.525 µs) : 482, 525
. : milestone, 504,
iast_INACTIVE (456.725 µs) : 435, 479
. : milestone, 457,
iast_TELEMETRY_OFF (495.274 µs) : 473, 518
. : milestone, 495,
tracing (450.753 µs) : 430, 472
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1333, 1372
. : milestone, 1352,
appsec (1.757 ms) : 1733, 1780
. : milestone, 1757,
appsec_no_iast (1.752 ms) : 1729, 1774
. : milestone, 1752,
iast (1.517 ms) : 1493, 1542
. : milestone, 1517,
profiling (1.502 ms) : 1479, 1525
. : milestone, 1502,
tracing (1.482 ms) : 1458, 1506
. : milestone, 1482,
section candidate
no_agent (1.35 ms) : 1330, 1370
. : milestone, 1350,
appsec (1.76 ms) : 1736, 1783
. : milestone, 1760,
appsec_no_iast (1.756 ms) : 1731, 1780
. : milestone, 1756,
iast (1.497 ms) : 1473, 1522
. : milestone, 1497,
profiling (1.509 ms) : 1486, 1533
. : milestone, 1509,
tracing (1.46 ms) : 1435, 1485
. : milestone, 1460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.36 ms) : 2317, 2403
. : milestone, 2360,
iast (2.109 ms) : 2054, 2164
. : milestone, 2109,
iast_GLOBAL (2.15 ms) : 2095, 2204
. : milestone, 2150,
profiling (1.97 ms) : 1926, 2015
. : milestone, 1970,
tracing (1.94 ms) : 1898, 1981
. : milestone, 1940,
section candidate
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (2.361 ms) : 2317, 2404
. : milestone, 2361,
iast (2.111 ms) : 2056, 2166
. : milestone, 2111,
iast_GLOBAL (2.153 ms) : 2099, 2208
. : milestone, 2153,
profiling (1.957 ms) : 1914, 2001
. : milestone, 1957,
tracing (1.945 ms) : 1902, 1987
. : milestone, 1945,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a83cee4eb4, baseline=1.46.0-SNAPSHOT~ad44687e99
dateFormat X
axisFormat %s
section baseline
no_agent (15.491 s) : 15491000, 15491000
. : milestone, 15491000,
appsec (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
iast (18.379 s) : 18379000, 18379000
. : milestone, 18379000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (15.292 s) : 15292000, 15292000
. : milestone, 15292000,
tracing (14.642 s) : 14642000, 14642000
. : milestone, 14642000,
section candidate
no_agent (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
appsec (14.71 s) : 14710000, 14710000
. : milestone, 14710000,
iast (19.162 s) : 19162000, 19162000
. : milestone, 19162000,
iast_GLOBAL (18.035 s) : 18035000, 18035000
. : milestone, 18035000,
profiling (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
tracing (14.654 s) : 14654000, 14654000
. : milestone, 14654000,
|
juan-fernandez
approved these changes
Jan 20, 2025
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/test-framework-tags-sync
branch
from
January 22, 2025 16:06
20a5542
to
a83cee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates the logic that sets
test.framework
andtest.framework_version
tags to do it atomically.Motivation
When test framework name and version are propagated from test to test suite span, some merging is done.
It is possible for multiple tests from the same suite to be executed in parallel, which is why the two tags need to be set atomically.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]