Attempt to upgrade i18next #10890
Open
Attempt to upgrade i18next #10890
+174
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to update i18next. The most significant change is that we must use the v4 JSON format, which mostly changes how plural keys are expressed.
I'm not 100% dialed into the translation process, so I'm not sure how we should update the other languages in Crowdin - I can run the upgrade script on them and import them if that'd help.
I also had to remove the "plural overrides" - I don't know what they were doing before, but adding resolvers at that part of the initialization of i18next doesn't work anymore. If they're something we need, we can maybe find a different place to install them.