Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds new cc and bank functions for ReferralCustomers #355

Closed
wants to merge 2 commits into from

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Jan 7, 2025

Description

  • Adds the following functions to assist ReferralCustomers add credit cards and bank accounts:
    • BetaReferralCustomerService.retrieve_credit_card_client_secret
    • BetaReferralCustomerService.retrieve_bank_account_client_secret
    • ReferralCustomerService.add_credit_card_from_stripe
    • ReferralCustomerService.add_bank_account_from_stripe

Testing

  • Adds tests for all functions, unfortunately because we don't have Stripe accounts for these test users we can't easily determine a valid assertion so like other functions of their kind, we assert the adjacent associated error to ensure we hit the right endpoint.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team as a code owner January 7, 2025 18:52
jchen293
jchen293 previously approved these changes Jan 7, 2025
nwithan8
nwithan8 previously approved these changes Jan 7, 2025
@Justintime50 Justintime50 dismissed stale reviews from nwithan8 and jchen293 via 0290400 January 7, 2025 23:44
@Justintime50
Copy link
Member Author

Shelving for now due to prioritization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants