Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pgaa.create_storage_location docs #6416

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

mildbyte
Copy link
Contributor

What Changed?

When creating a storage location, all parameters are required in 0.1.x of pgaa, so make them explicit and use the => syntax so that it's obvious which one goes where.

All parameters are required in 0.1.x of pgaa, so make them
explicit and use the `=>` syntax so that it's obvious
which one goes where.

This will change in 0.2 of pgaa anyway since it'll use
pgfs.
@mildbyte mildbyte requested a review from a team as a code owner January 20, 2025 09:00
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw-m djw-m merged commit 1e15d57 into develop Jan 20, 2025
5 checks passed
@djw-m djw-m deleted the bugfix/pgaa-external-table-fixes branch January 20, 2025 09:27
@djw-m djw-m mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants