Remove reward_range #1167
Merged
Remove reward_range #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedTachyon
force-pushed
the
remove_reward_range
branch
from
c9c6613 to
9670411
Compare
pseudo-rnd-thoughts
approved these changes
Sep 19, 2024
Kallinteris-Andreas
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reward_rangeis one of the relics of the wild west approach to API design of Gym. It's not really used ever, it doesn't really have a well defined meaning, so we're removing it from 1.0.This PR removes it from code (making it a breaking change), and hopefully removes all mentions of it in documentation