Skip to content

Commit

Permalink
Fix #274: add proper module-info.java handling
Browse files Browse the repository at this point in the history
  • Loading branch information
cowtowncoder committed Jan 11, 2025
1 parent f183a99 commit 4653947
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
6 changes: 0 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ https://stackoverflow.com/questions/16302247/maven-property-project-artifact-sel
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>${version.junit5}</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -99,11 +98,6 @@ https://stackoverflow.com/questions/16302247/maven-property-project-artifact-sel

<build>
<plugins>
<plugin>
<groupId>org.moditect</groupId>
<artifactId>moditect-maven-plugin</artifactId>
</plugin>

<!-- 08-Nov-2019, tatu: Copied from
https://github.com/stephenc/git-timestamp-maven-plugin/blob/master/pom.xml#L327-L337
-->
Expand Down
1 change: 1 addition & 0 deletions release-notes/VERSION
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ mostly)
3.0 (not yet released)

#272: Require JDK17 for jackson-annotations 3.0 for proper `module-info.java`
#274: Change 3.0 to use `module-info.java` directly for build (instead of via Moditect)
- Change `JsonInclude.value`, `JsonInclude.content` to `USE_DEFAULTS` (from `ALWAYS`)
5 changes: 5 additions & 0 deletions src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// Jackson 3.x module-info for jackson-annotations Main artifact
module com.fasterxml.jackson.annotation {
// Might not be required beyond exports but just in case:
opens com.fasterxml.jackson.annotation;
}
7 changes: 0 additions & 7 deletions src/moditect/module-info.java

This file was deleted.

0 comments on commit 4653947

Please sign in to comment.