Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSTEP-10] Add failing test utils #1371

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

JooHyukKim
Copy link
Member

part of #1370.

Moving tests & cleaning up will follow

@cowtowncoder cowtowncoder merged commit 5f7bd4c into FasterXML:2.19 Dec 30, 2024
8 checks passed
@cowtowncoder
Copy link
Member

@JooHyukKim One idea -- not sure how easy to do, but possible -- it is possible to export and publish separate test jar by Maven, to share common test classes. If so, that should probably be done from jackson-core since almost everything else depends on it (directly or indirectly). If so, it could include these 3 classes, plus some version of current JUnit5TestBase (which can then be extended by module-specific classes like DatabindTestUtil)

@JooHyukKim JooHyukKim deleted the start-1370 branch December 30, 2024 10:54
@JooHyukKim
Copy link
Member Author

JooHyukKim commented Dec 30, 2024

Hmmmm, I clearly see how we could benefit from it. But I am not sure if it is more beneficial to do it during 2->3 transition phase.

I am concerned that it would sort of expand JSTEP-10's scope more, which also means we have less time to touch other TODO 3.0 things as well.

EDIT : Or maybe it actually is do the module thing now and I am not just aware of the reason?

@cowtowncoder
Copy link
Member

@JooHyukKim Maybe we should allow bit of duplication at first, and get bigger conversion done now. And then test-jar publishing could be for 3.0 only, as the next step.

So let's defer reusability concern after more of conversion has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants