Suppport simple deserialization of Cache
#116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
May 3, 2023
| return deserializeContents(p, ctxt); | ||
| } | ||
|
|
||
| private T deserializeContents(JsonParser p, DeserializationContext ctxt) |
There was a problem hiding this comment.
JooHyukKim
commented
May 3, 2023
Comment on lines
+137
to
+150
| p.nextToken(); | ||
|
|
||
| final Object value; | ||
| if (p.currentToken() == JsonToken.VALUE_NULL) { | ||
| if (skipNullValues) { | ||
| continue; | ||
| } | ||
| value = nullProvider.getNullValue(ctxt); | ||
| } else if (elementTypeDeserializer != null) { | ||
| value = elementDeserializer.deserializeWithType(p, ctxt, elementTypeDeserializer); | ||
| } else { | ||
| value = elementDeserializer.deserialize(p, ctxt); | ||
| } | ||
| cache.put(key, value); |
There was a problem hiding this comment.
Referenced most from...
Exception this part where we do not assume the value is array like
cowtowncoder
reviewed
May 4, 2023
|
|
||
| public void testGuavaCacheApi() throws Exception { | ||
| Cache<String, String> cache = CacheBuilder.newBuilder().build(); | ||
| // Cache does not allow null key |
There was a problem hiding this comment.
I am ok with this, but in general it's not necessary to test dependencies of a library (they are assumed to work as specified).
cowtowncoder
approved these changes
May 4, 2023
cowtowncoder
changed the title
CacheCache
cowtowncoder
added a commit
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports deserialization side of
Cachefollowing #112.Notes
Cacheitself heavily relies on builder mechanism throughCacheBuilderso it is most likely we cannot initialize by its subclasses.GuavaMultimapDeserializerLike how [Guava] AllowCacheserialization #112 Cache serialization was implemented.