[WIP] Fixing Nginx support #60
Conversation
First draft for doc and the basic conf Nginx class now extends AbstractCacheProxy #34 - Added purging test for different location setup Fixing Scrutinizer issue Update NginxTestCase.php Refresh method and test Removed empty line Few more CS fix Added nginx as keyword Added nginx to Travis Added HTTPS Typo Removed empty line added nginx installation script on travis before_script Nginx custom build script Few fix for nginx installation process Correct path Correct path Merging classes Sperate/Same Location Removed useless config directives All NGINX files are now set to /tmp Set more NGINX conf to /tmp/ Install custom NGINX the other way Update install-nginx.sh Fixing permissions New method addRiskyTest required for phpunit >= 4 Installation is needed Add shebang Remove NginxSeparateLocation Also support same location
- Expanded purge & refresh tests and new expired test - Remove cache TTL in proxy_cache_valid (as suggested by @ddeboer) - Custom log for better debug - Improve installing nginx for testing
|
@hpatoio Do you mean the way the Varnish cache is emptied? What don't you like about it? |
|
Well. It just seems a trick to me. If stop/start the daemon has also other effects strange behavior might happen. The user think that he is only clearing the cache but he is actually restarting the daemon. |
|
As the |
|
i think its fine for the test that we restart varnish to be sure everything is gone. everything else would rely on the vcl being correctly set up with banning. unless we would implement the varnishadm communication port stuff in FriendsOfSymfony/FOSHttpCacheBundle#14 (and then all tests would depend on that bit working correctly...) |
|
One questions for @dbu : what did you want to test with |
|
@hpatoio one is sending the hostname along, the other only a path, meaning the default host needs to be added in the right place. |
|
Well, I don't understand why I should specify the hostname when I purge an URL. Purge requests are sent to the proxies using IPs not application's hostname so why specify it ? Just to remove it ? |
|
lests assume i have site-a.com and site-b.com and both have /page. now i want to purge site-a.com/page but not site-b.com/page. |
|
merged manually to #49 |
resetProxyDaemonvarnishadm?Tests are still red and I need to modify how
purgegenerate the purging URL. A fix is coming