impl Display for Receipt
#901
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Jan 21, 2025
| @@ -156,6 +156,51 @@ pub enum Receipt { | |||
| }, | |||
| } | |||
|
|
|||
| impl core::fmt::Display for Receipt { | |||
There was a problem hiding this comment.
Why can't we derive the implementation with all fields?=D
There was a problem hiding this comment.
Regarding all fields - I thought it may be just a bit too much details, which, when needed, could be retrieved by Debug. I prefer Display to be more concise, targeted on humans, not developers :)
I have no strong opinions here, so if you prefer to have all fields, I can just stick derive_more::Display without any custom #[display(fmt = attributes.
Let me know what you think.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
DisplayforReceiptfor easier logging.Once this is merged and released, there will be a follow-up PR to the
fuel-coreto get rid of this boilerplate.Follow-up PR: FuelLabs/fuel-core#2616
Checklist
Before requesting review